[6/8] qla2xxx: klocwork - pointer may be dereferenced

Message ID	20230518075841.40363-7-njavali@marvell.com
State	New
Headers	show Return-Path: <linux-scsi-owner@vger.kernel.org> From: Nilesh Javali <njavali@marvell.com> To: <martin.petersen@oracle.com> CC: <linux-scsi@vger.kernel.org>, <GR-QLogic-Storage-Upstream@marvell.com>, <bhazarika@marvell.com>, <agurumurthy@marvell.com>, <sdeodhar@marvell.com> Subject: [PATCH 6/8] qla2xxx: klocwork - pointer may be dereferenced Date: Thu, 18 May 2023 13:28:39 +0530 Message-ID: <20230518075841.40363-7-njavali@marvell.com> In-Reply-To: <20230518075841.40363-1-njavali@marvell.com> References: <20230518075841.40363-1-njavali@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Precedence: bulk
Series	qla2xxx klocwork fixes \| expand [0/8] qla2xxx klocwork fixes [1/8] qla2xxx: klocwork - Array index may go out of bound [2/8] qla2xxx: klocwork - Fix potential null pointer dereference [3/8] qla2xxx: klocwork - Check for a valid fcport pointer [4/8] qla2xxx: klocwork - Check valid rport returned by fc_bsg_to_rport [5/8] qla2xxx: klocwork - Fix buffer overrun [6/8] qla2xxx: klocwork - pointer may be dereferenced [7/8] qla2xxx: klocwork - correct the index of array [8/8] qla2xxx: Update version to 10.02.08.400-k

Message ID

20230518075841.40363-7-njavali@marvell.com

State

New

Headers

From: Nilesh Javali <njavali@marvell.com>
To: <martin.petersen@oracle.com>
CC: <linux-scsi@vger.kernel.org>,
        <GR-QLogic-Storage-Upstream@marvell.com>, <bhazarika@marvell.com>,
        <agurumurthy@marvell.com>, <sdeodhar@marvell.com>
Subject: [PATCH 6/8] qla2xxx: klocwork - pointer may be dereferenced
Date: Thu, 18 May 2023 13:28:39 +0530
Message-ID: <20230518075841.40363-7-njavali@marvell.com>
In-Reply-To: <20230518075841.40363-1-njavali@marvell.com>
References: <20230518075841.40363-1-njavali@marvell.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk

Series

qla2xxx klocwork fixes | expand

Commit Message

Nilesh Javali May 18, 2023, 7:58 a.m. UTC

From: Shreyas Deodhar <sdeodhar@marvell.com>

Klocwork tool reported pointer 'rport' returned
from call to function 'fc_bsg_to_rport' may be
NULL and will be dereferenced.

Add a fix to validate rport before dereferencing.

Cc: stable@vger.kernel.org
Signed-off-by: Shreyas Deodhar <sdeodhar@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
---
 drivers/scsi/qla2xxx/qla_bsg.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/scsi/qla2xxx/qla_bsg.c b/drivers/scsi/qla2xxx/qla_bsg.c
index c928b27061a9..19bb64bdd88b 100644
--- a/drivers/scsi/qla2xxx/qla_bsg.c
+++ b/drivers/scsi/qla2xxx/qla_bsg.c
@@ -2996,6 +2996,8 @@  qla24xx_bsg_request(struct bsg_job *bsg_job)
 
 	if (bsg_request->msgcode == FC_BSG_RPT_ELS) {
 		rport = fc_bsg_to_rport(bsg_job);
+		if (!rport)
+			return ret;
 		host = rport_to_shost(rport);
 		vha = shost_priv(host);
 	} else {

[6/8] qla2xxx: klocwork - pointer may be dereferenced

Commit Message

Patch