diff mbox series

[v5,1/2] drm/msm/dp: no need to disable irq after devm_request_irq()

Message ID 1684870754-24906-2-git-send-email-quic_khsieh@quicinc.com
State New
Headers show
Series enable HDP plug/unpulg interrupts at hpd_enable/disable | expand

Commit Message

Kuogee Hsieh May 23, 2023, 7:39 p.m. UTC 
devm_request_irq() will allocate irq and return with irq enabled.
At current implementation irq are specified disabled after return from
devm_request_irq() and re enabled later. It is redundant.

Fixes: 8ede2ecc3e5e ("drm/msm/dp: Add DP compliance tests on Snapdragon Chipsets")
Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com>
---
 drivers/gpu/drm/msm/dp/dp_display.c | 9 ---------
 1 file changed, 9 deletions(-)
diff mbox series

Patch

diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
index 3e13acdf..1af49b6 100644
--- a/drivers/gpu/drm/msm/dp/dp_display.c
+++ b/drivers/gpu/drm/msm/dp/dp_display.c
@@ -1094,12 +1094,6 @@  static void dp_display_config_hpd(struct dp_display_private *dp)
 				DP_DP_HPD_PLUG_INT_MASK |
 				DP_DP_HPD_UNPLUG_INT_MASK,
 				true);
-
-	/* Enable interrupt first time
-	 * we are leaving dp clocks on during disconnect
-	 * and never disable interrupt
-	 */
-	enable_irq(dp->irq);
 }
 
 void dp_display_set_psr(struct msm_dp *dp_display, bool enter)
@@ -1282,7 +1276,6 @@  int dp_display_request_irq(struct msm_dp *dp_display)
 				dp->irq, rc);
 		return rc;
 	}
-	disable_irq(dp->irq);
 
 	return 0;
 }
@@ -1570,7 +1563,6 @@  static int dp_display_get_next_bridge(struct msm_dp *dp)
 		dp_display_host_init(dp_priv);
 		dp_catalog_ctrl_hpd_config(dp_priv->catalog);
 		dp_display_host_phy_init(dp_priv);
-		enable_irq(dp_priv->irq);
 
 		/*
 		 * The code below assumes that the panel will finish probing
@@ -1612,7 +1604,6 @@  static int dp_display_get_next_bridge(struct msm_dp *dp)
 
 error:
 	if (dp->is_edp) {
-		disable_irq(dp_priv->irq);
 		dp_display_host_phy_exit(dp_priv);
 		dp_display_host_deinit(dp_priv);
 	}