| Message ID | 20230526093150.22923-8-trevor.wu@mediatek.com |
|---|---|
| State | Accepted |
| Commit | ee02b869dcad7ba3772b58e93dd90ab4f932fac5 |
| Headers | show |
| Series | ASoC: mt8188: add new board support | expand |
On Fri, May 26, 2023 at 05:31:50PM +0800, Trevor Wu wrote: > + dai-format: > + description: audio format. > + items: > + enum: > + - i2s > + - right_j > + - left_j > + - dsp_a > + - dsp_b Why is this a DT property - why not just pick one in the driver given that it's for a machine with a specific CODEC?
On Thu, 2023-06-01 at 12:29 +0100, Mark Brown wrote: > On Fri, May 26, 2023 at 05:31:50PM +0800, Trevor Wu wrote: > > > + dai-format: > > + description: audio format. > > + items: > > + enum: > > + - i2s > > + - right_j > > + - left_j > > + - dsp_a > > + - dsp_b > > Why is this a DT property - why not just pick one in the driver given > that it's for a machine with a specific CODEC? Hi Mark, We aim to reuse the machine driver for various codec combinations. To achieve this, I included the property that allows overwriting of the default configuration in the machine driver. Thanks, Trevor
diff --git a/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml b/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml index 3d2c01b693be..05e532b5d50a 100644 --- a/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml +++ b/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml @@ -11,7 +11,9 @@ maintainers: properties: compatible: - const: mediatek,mt8188-mt6359-evb + enum: + - mediatek,mt8188-mt6359-evb + - mediatek,mt8188-nau8825 model: $ref: /schemas/types.yaml#/definitions/string @@ -61,11 +63,28 @@ patternProperties: required: - sound-dai + dai-format: + description: audio format. + items: + enum: + - i2s + - right_j + - left_j + - dsp_a + - dsp_b + + mediatek,clk-provider: + $ref: /schemas/types.yaml#/definitions/string + description: Indicates dai-link clock master. + items: + enum: + - cpu + - codec + additionalProperties: false required: - link-name - - codec additionalProperties: false @@ -86,7 +105,8 @@ examples: "AIN1", "Headset Mic"; dai-link-0 { link-name = "ETDM3_OUT_BE"; - + dai-format = "i2s"; + mediatek,clk-provider = "cpu"; codec { sound-dai = <&hdmi0>; };
Add compatible string "mediatek,mt8188-nau8825" to support new board with nau8825 codec. Introduce two properties "dai-format" and "mediatek,clk-provider" under dai-link subnode to configure dai-link parameters via dts. "codec" property is removed from required property of dai-link subnode. For co-clock case, it's possible two dai-links should be configured to the same dai format, but only one cpu dai is bound with codec. Signed-off-by: Trevor Wu <trevor.wu@mediatek.com> --- .../sound/mediatek,mt8188-mt6359.yaml | 26 ++++++++++++++++--- 1 file changed, 23 insertions(+), 3 deletions(-)