diff mbox series

scsi: qla2xxx: Fix memleak on memory alloc failed

Message ID 20230526161936.1433332-1-liu.yun@linux.dev
State New
Headers show
Series scsi: qla2xxx: Fix memleak on memory alloc failed | expand

Commit Message

Jackie Liu May 26, 2023, 4:19 p.m. UTC 
From: Jackie Liu <liuyun01@kylinos.cn>

Returning directly without free memory can lead to memory leaks, which
can be avoided by goto 'fail_dma_pool'.

Fixes: 06634d5b6e92 ("scsi: qla2xxx: Return -ENOMEM if kzalloc() fails")
Reported-by: k2ci <kernel-bot@kylinos.cn>
Signed-off-by: Jackie Liu <liuyun01@kylinos.cn>
---
 drivers/scsi/qla2xxx/qla_os.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index 2fa695bf38b7..da7698c8293b 100644
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -4245,7 +4245,7 @@  qla2x00_mem_alloc(struct qla_hw_data *ha, uint16_t req_len, uint16_t rsp_len,
 					ql_dbg_pci(ql_dbg_init, ha->pdev,
 					    0xe0ee, "%s: failed alloc dsd\n",
 					    __func__);
-					return -ENOMEM;
+					goto fail_dma_pool;
 				}
 				ha->dif_bundle_kallocs++;