| Message ID | 20230530213259.1776512-1-robimarko@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | mmc: core: disable TRIM on Micron MTFC4GACAJCN-1M | expand |
+Bean Thanks, Avri > It seems that Micron MTFC4GACAJCN-1M despite advertising TRIM support > does not work when the core is trying to use REQ_OP_WRITE_ZEROES. > > We are seeing the following errors in OpenWrt under 6.1 on Qnap Qhora > 301W that we did not previously have and tracked it down to > REQ_OP_WRITE_ZEROES: > [ 18.085950] I/O error, dev loop0, sector 596 op 0x9:(WRITE_ZEROES) flags > 0x800 phys_seg 0 prio class 2 > > Disabling TRIM makes the error go away, so lets add a quirk for this eMMC to > disable TRIM. > > Signed-off-by: Robert Marko <robimarko@gmail.com> > --- > drivers/mmc/core/quirks.h | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/mmc/core/quirks.h b/drivers/mmc/core/quirks.h index > 29b9497936df..77caa0c903f8 100644 > --- a/drivers/mmc/core/quirks.h > +++ b/drivers/mmc/core/quirks.h > @@ -100,6 +100,13 @@ static const struct mmc_fixup __maybe_unused > mmc_blk_fixups[] = { > MMC_FIXUP("V10016", CID_MANFID_KINGSTON, CID_OEMID_ANY, > add_quirk_mmc, > MMC_QUIRK_TRIM_BROKEN), > > + /* > + * Micron MTFC4GACAJCN-1M advertises TRIM but it does not seems to > + * support being used to offload WRITE_ZEROES. > + */ > + MMC_FIXUP("Q2J54A", CID_MANFID_MICRON, 0x014e, add_quirk_mmc, > + MMC_QUIRK_TRIM_BROKEN), > + > /* > * Some SD cards reports discard support while they don't > */ > -- > 2.40.1
+ Luca (Bean was added by Avri in another thread) On Tue, 30 May 2023 at 23:33, Robert Marko <robimarko@gmail.com> wrote: > > It seems that Micron MTFC4GACAJCN-1M despite advertising TRIM support does > not work when the core is trying to use REQ_OP_WRITE_ZEROES. > > We are seeing the following errors in OpenWrt under 6.1 on Qnap Qhora 301W > that we did not previously have and tracked it down to REQ_OP_WRITE_ZEROES: > [ 18.085950] I/O error, dev loop0, sector 596 op 0x9:(WRITE_ZEROES) flags 0x800 phys_seg 0 prio class 2 > > Disabling TRIM makes the error go away, so lets add a quirk for this eMMC > to disable TRIM. Let's leave this another week or so, to allow Micron folkz to confirm before applying. > > Signed-off-by: Robert Marko <robimarko@gmail.com> Kind regards Uffe > --- > drivers/mmc/core/quirks.h | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/mmc/core/quirks.h b/drivers/mmc/core/quirks.h > index 29b9497936df..77caa0c903f8 100644 > --- a/drivers/mmc/core/quirks.h > +++ b/drivers/mmc/core/quirks.h > @@ -100,6 +100,13 @@ static const struct mmc_fixup __maybe_unused mmc_blk_fixups[] = { > MMC_FIXUP("V10016", CID_MANFID_KINGSTON, CID_OEMID_ANY, add_quirk_mmc, > MMC_QUIRK_TRIM_BROKEN), > > + /* > + * Micron MTFC4GACAJCN-1M advertises TRIM but it does not seems to > + * support being used to offload WRITE_ZEROES. > + */ > + MMC_FIXUP("Q2J54A", CID_MANFID_MICRON, 0x014e, add_quirk_mmc, > + MMC_QUIRK_TRIM_BROKEN), > + > /* > * Some SD cards reports discard support while they don't > */ > -- > 2.40.1 >
On Fri, 9 Jun 2023 at 00:18, Ulf Hansson <ulf.hansson@linaro.org> wrote: > > + Luca (Bean was added by Avri in another thread) > > On Tue, 30 May 2023 at 23:33, Robert Marko <robimarko@gmail.com> wrote: > > > > It seems that Micron MTFC4GACAJCN-1M despite advertising TRIM support does > > not work when the core is trying to use REQ_OP_WRITE_ZEROES. > > > > We are seeing the following errors in OpenWrt under 6.1 on Qnap Qhora 301W > > that we did not previously have and tracked it down to REQ_OP_WRITE_ZEROES: > > [ 18.085950] I/O error, dev loop0, sector 596 op 0x9:(WRITE_ZEROES) flags 0x800 phys_seg 0 prio class 2 > > > > Disabling TRIM makes the error go away, so lets add a quirk for this eMMC > > to disable TRIM. > > Let's leave this another week or so, to allow Micron folkz to confirm > before applying. > > > > > Signed-off-by: Robert Marko <robimarko@gmail.com> Applied for next and by adding a stable tag, thanks! Kind regards Uffe > > > --- > > drivers/mmc/core/quirks.h | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/drivers/mmc/core/quirks.h b/drivers/mmc/core/quirks.h > > index 29b9497936df..77caa0c903f8 100644 > > --- a/drivers/mmc/core/quirks.h > > +++ b/drivers/mmc/core/quirks.h > > @@ -100,6 +100,13 @@ static const struct mmc_fixup __maybe_unused mmc_blk_fixups[] = { > > MMC_FIXUP("V10016", CID_MANFID_KINGSTON, CID_OEMID_ANY, add_quirk_mmc, > > MMC_QUIRK_TRIM_BROKEN), > > > > + /* > > + * Micron MTFC4GACAJCN-1M advertises TRIM but it does not seems to > > + * support being used to offload WRITE_ZEROES. > > + */ > > + MMC_FIXUP("Q2J54A", CID_MANFID_MICRON, 0x014e, add_quirk_mmc, > > + MMC_QUIRK_TRIM_BROKEN), > > + > > /* > > * Some SD cards reports discard support while they don't > > */ > > -- > > 2.40.1 > >
On Mon, 19 Jun 2023 at 13:43, Ulf Hansson <ulf.hansson@linaro.org> wrote: > > On Fri, 9 Jun 2023 at 00:18, Ulf Hansson <ulf.hansson@linaro.org> wrote: > > > > + Luca (Bean was added by Avri in another thread) > > > > On Tue, 30 May 2023 at 23:33, Robert Marko <robimarko@gmail.com> wrote: > > > > > > It seems that Micron MTFC4GACAJCN-1M despite advertising TRIM support does > > > not work when the core is trying to use REQ_OP_WRITE_ZEROES. > > > > > > We are seeing the following errors in OpenWrt under 6.1 on Qnap Qhora 301W > > > that we did not previously have and tracked it down to REQ_OP_WRITE_ZEROES: > > > [ 18.085950] I/O error, dev loop0, sector 596 op 0x9:(WRITE_ZEROES) flags 0x800 phys_seg 0 prio class 2 > > > > > > Disabling TRIM makes the error go away, so lets add a quirk for this eMMC > > > to disable TRIM. > > > > Let's leave this another week or so, to allow Micron folkz to confirm > > before applying. > > > > > > > > Signed-off-by: Robert Marko <robimarko@gmail.com> > > Applied for next and by adding a stable tag, thanks! Thanks, I have sent the patch for one of Kingstom eMMC as well that seems to have TRIM broken as well. Regards, Robert > > > Kind regards > Uffe > > > > > > --- > > > drivers/mmc/core/quirks.h | 7 +++++++ > > > 1 file changed, 7 insertions(+) > > > > > > diff --git a/drivers/mmc/core/quirks.h b/drivers/mmc/core/quirks.h > > > index 29b9497936df..77caa0c903f8 100644 > > > --- a/drivers/mmc/core/quirks.h > > > +++ b/drivers/mmc/core/quirks.h > > > @@ -100,6 +100,13 @@ static const struct mmc_fixup __maybe_unused mmc_blk_fixups[] = { > > > MMC_FIXUP("V10016", CID_MANFID_KINGSTON, CID_OEMID_ANY, add_quirk_mmc, > > > MMC_QUIRK_TRIM_BROKEN), > > > > > > + /* > > > + * Micron MTFC4GACAJCN-1M advertises TRIM but it does not seems to > > > + * support being used to offload WRITE_ZEROES. > > > + */ > > > + MMC_FIXUP("Q2J54A", CID_MANFID_MICRON, 0x014e, add_quirk_mmc, > > > + MMC_QUIRK_TRIM_BROKEN), > > > + > > > /* > > > * Some SD cards reports discard support while they don't > > > */ > > > -- > > > 2.40.1 > > >
diff --git a/drivers/mmc/core/quirks.h b/drivers/mmc/core/quirks.h index 29b9497936df..77caa0c903f8 100644 --- a/drivers/mmc/core/quirks.h +++ b/drivers/mmc/core/quirks.h @@ -100,6 +100,13 @@ static const struct mmc_fixup __maybe_unused mmc_blk_fixups[] = { MMC_FIXUP("V10016", CID_MANFID_KINGSTON, CID_OEMID_ANY, add_quirk_mmc, MMC_QUIRK_TRIM_BROKEN), + /* + * Micron MTFC4GACAJCN-1M advertises TRIM but it does not seems to + * support being used to offload WRITE_ZEROES. + */ + MMC_FIXUP("Q2J54A", CID_MANFID_MICRON, 0x014e, add_quirk_mmc, + MMC_QUIRK_TRIM_BROKEN), + /* * Some SD cards reports discard support while they don't */
It seems that Micron MTFC4GACAJCN-1M despite advertising TRIM support does not work when the core is trying to use REQ_OP_WRITE_ZEROES. We are seeing the following errors in OpenWrt under 6.1 on Qnap Qhora 301W that we did not previously have and tracked it down to REQ_OP_WRITE_ZEROES: [ 18.085950] I/O error, dev loop0, sector 596 op 0x9:(WRITE_ZEROES) flags 0x800 phys_seg 0 prio class 2 Disabling TRIM makes the error go away, so lets add a quirk for this eMMC to disable TRIM. Signed-off-by: Robert Marko <robimarko@gmail.com> --- drivers/mmc/core/quirks.h | 7 +++++++ 1 file changed, 7 insertions(+)