diff mbox series

spi: dw: announce driver probe

Message ID 20230531110339.321387-1-ben.dooks@codethink.co.uk
State New
Headers show
Series spi: dw: announce driver probe | expand

Commit Message

Ben Dooks May 31, 2023, 11:03 a.m. UTC 
From: Ben Dooks <ben.dooks@sifive.com>

It is useful to know the driver probed, so print some basic
info when it does, such as the spi bus name, irq, etc.

Signed-off-by: Ben Dooks <ben.dooks@sifive.com>
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
 drivers/spi/spi-dw-core.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Mark Brown May 31, 2023, 11:24 a.m. UTC | #1 
On Wed, May 31, 2023 at 12:03:39PM +0100, Ben Dooks wrote:

> It is useful to know the driver probed, so print some basic
> info when it does, such as the spi bus name, irq, etc.

No, we don't want every driver spamming the logs at probe - apart from
anything else this slows down boot.  There's already some standard
logging from the driver core that can be turned on if needed for debug
purposes.  If there's things being enumerated from the hardware it can
be useful to record those but that's chip revisions and so on rather
than things like interrupt numbers.
diff mbox series

Patch

diff --git a/drivers/spi/spi-dw-core.c b/drivers/spi/spi-dw-core.c
index 071a7604a8ab..8e8a0d063519 100644
--- a/drivers/spi/spi-dw-core.c
+++ b/drivers/spi/spi-dw-core.c
@@ -958,6 +958,9 @@  int dw_spi_add_host(struct device *dev, struct dw_spi *dws)
 		goto err_dma_exit;
 	}
 
+	dev_info(dev, "%s: irq %d, %d fifo, max freq %u",
+		 dev_name(&master->dev), dws->irq, dws->fifo_len,
+		 dws->max_freq);
 	dw_spi_debugfs_init(dws);
 	return 0;