| Message ID | 1464862996-3147-3-git-send-email-srinivas.kandagatla@linaro.org |
|---|---|
| State | Accepted |
| Commit | a8a47540ebe32f1733eebc3e5699af580ceaa3f5 |
| Headers | show |
On Thu, Jun 02, 2016 at 11:23:15AM +0100, Srinivas Kandagatla wrote: > This patch adds support to list_voltage callback, so that consumers > like mmc core, can get information of supported voltage range. > > Without this patch there is no way for mmc core to know this voltage range. Something I applied yesterday, most likely this, seems to have broken boot on a large proportion of (potentially all) 32 bit Qualcomm platforms: https://kernelci.org/boot/all/job/broonie-regulator/kernel/v4.7-rc1-10-gafafb91512cf/ I suspect this is because the fixed voltage regulator is triggering a crash as it has no linear ranges defined. Please get me a fix ASAP.
On 03/06/16 11:40, Mark Brown wrote: > On Thu, Jun 02, 2016 at 11:23:15AM +0100, Srinivas Kandagatla wrote: >> This patch adds support to list_voltage callback, so that consumers >> like mmc core, can get information of supported voltage range. >> >> Without this patch there is no way for mmc core to know this voltage range. > > Something I applied yesterday, most likely this, seems to have broken > boot on a large proportion of (potentially all) 32 bit Qualcomm > platforms: > > https://kernelci.org/boot/all/job/broonie-regulator/kernel/v4.7-rc1-10-gafafb91512cf/ > > I suspect this is because the fixed voltage regulator is triggering a > crash as it has no linear ranges defined. Please get me a fix ASAP. Yes, looks like it is because of the fixed regulator thing, I send a patch with separate ops for this. --srini > -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/regulator/qcom_smd-regulator.c b/drivers/regulator/qcom_smd-regulator.c index 56a17ec..b11b627 100644 --- a/drivers/regulator/qcom_smd-regulator.c +++ b/drivers/regulator/qcom_smd-regulator.c @@ -140,6 +140,7 @@ static const struct regulator_ops rpm_smps_ldo_ops = { .enable = rpm_reg_enable, .disable = rpm_reg_disable, .is_enabled = rpm_reg_is_enabled, + .list_voltage = regulator_list_voltage_linear_range, .get_voltage = rpm_reg_get_voltage, .set_voltage = rpm_reg_set_voltage,
This patch adds support to list_voltage callback, so that consumers like mmc core, can get information of supported voltage range. Without this patch there is no way for mmc core to know this voltage range. Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> --- drivers/regulator/qcom_smd-regulator.c | 1 + 1 file changed, 1 insertion(+) -- 2.8.2 -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html