diff mbox series

spi: dw: Replace incorrect spi_get_chipselect with set

Message ID 20230613162103.569812-1-abe.kohandel@intel.com
State Accepted
Commit eee43699217504ba69cadefc85c6992df555e33f
Headers show
Series spi: dw: Replace incorrect spi_get_chipselect with set | expand

Commit Message

Abe Kohandel June 13, 2023, 4:21 p.m. UTC
Commit 445164e8c136 ("spi: dw: Replace spi->chip_select references with
function calls") replaced direct access to spi.chip_select with
spi_*_chipselect calls but incorrectly replaced a set instance with a
get instance, replace the incorrect instance.

Fixes: 445164e8c136 ("spi: dw: Replace spi->chip_select references with function calls")
Signed-off-by: Abe Kohandel <abe.kohandel@intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/spi/spi-dw-mmio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Serge Semin June 13, 2023, 7:02 p.m. UTC | #1
On Tue, Jun 13, 2023 at 09:21:03AM -0700, Abe Kohandel wrote:
> Commit 445164e8c136 ("spi: dw: Replace spi->chip_select references with
> function calls") replaced direct access to spi.chip_select with
> spi_*_chipselect calls but incorrectly replaced a set instance with a
> get instance, replace the incorrect instance.
> 
> Fixes: 445164e8c136 ("spi: dw: Replace spi->chip_select references with function calls")
> Signed-off-by: Abe Kohandel <abe.kohandel@intel.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Indeed! Thanks for fixing this.
Acked-by: Serge Semin <fancer.lancer@gmail.com>

-Serge(y)

> ---
>  drivers/spi/spi-dw-mmio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-dw-mmio.c b/drivers/spi/spi-dw-mmio.c
> index a699ce496cc5..a963bc96c223 100644
> --- a/drivers/spi/spi-dw-mmio.c
> +++ b/drivers/spi/spi-dw-mmio.c
> @@ -292,7 +292,7 @@ static void dw_spi_elba_set_cs(struct spi_device *spi, bool enable)
>  	 */
>  	spi_set_chipselect(spi, 0, 0);
>  	dw_spi_set_cs(spi, enable);
> -	spi_get_chipselect(spi, cs);
> +	spi_set_chipselect(spi, 0, cs);
>  }
>  
>  static int dw_spi_elba_init(struct platform_device *pdev,
> -- 
> 2.40.1
>
Mark Brown June 13, 2023, 8:12 p.m. UTC | #2
On Tue, 13 Jun 2023 09:21:03 -0700, Abe Kohandel wrote:
> Commit 445164e8c136 ("spi: dw: Replace spi->chip_select references with
> function calls") replaced direct access to spi.chip_select with
> spi_*_chipselect calls but incorrectly replaced a set instance with a
> get instance, replace the incorrect instance.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: dw: Replace incorrect spi_get_chipselect with set
      commit: eee43699217504ba69cadefc85c6992df555e33f

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/drivers/spi/spi-dw-mmio.c b/drivers/spi/spi-dw-mmio.c
index a699ce496cc5..a963bc96c223 100644
--- a/drivers/spi/spi-dw-mmio.c
+++ b/drivers/spi/spi-dw-mmio.c
@@ -292,7 +292,7 @@  static void dw_spi_elba_set_cs(struct spi_device *spi, bool enable)
 	 */
 	spi_set_chipselect(spi, 0, 0);
 	dw_spi_set_cs(spi, enable);
-	spi_get_chipselect(spi, cs);
+	spi_set_chipselect(spi, 0, cs);
 }
 
 static int dw_spi_elba_init(struct platform_device *pdev,