| Message ID | 20230613114904.15749-2-frank.li@vivo.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v3,01/12] thermal/hwmon: Add error information printing for devm_thermal_add_hwmon_sysfs() | expand |
Dne torek, 13. junij 2023 ob 13:48:54 CEST je Yangtao Li napisal(a): > The upper-layer devm_thermal_add_hwmon_sysfs() function can directly > print error information. > > Signed-off-by: Yangtao Li <frank.li@vivo.com> Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com> Best regards, Jernej > --- > drivers/thermal/sun8i_thermal.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/thermal/sun8i_thermal.c b/drivers/thermal/sun8i_thermal.c > index 793ddce72132..066f9fed9b86 100644 > --- a/drivers/thermal/sun8i_thermal.c > +++ b/drivers/thermal/sun8i_thermal.c > @@ -475,9 +475,7 @@ static int sun8i_ths_register(struct ths_device *tmdev) > if (IS_ERR(tmdev->sensor[i].tzd)) > return PTR_ERR(tmdev->sensor[i].tzd); > > - if (devm_thermal_add_hwmon_sysfs(tmdev->dev, tmdev->sensor[i].tzd)) > - dev_warn(tmdev->dev, > - "Failed to add hwmon sysfs attributes\n"); > + devm_thermal_add_hwmon_sysfs(tmdev->dev, tmdev->sensor[i].tzd); > } > > return 0; >
diff --git a/drivers/thermal/sun8i_thermal.c b/drivers/thermal/sun8i_thermal.c index 793ddce72132..066f9fed9b86 100644 --- a/drivers/thermal/sun8i_thermal.c +++ b/drivers/thermal/sun8i_thermal.c @@ -475,9 +475,7 @@ static int sun8i_ths_register(struct ths_device *tmdev) if (IS_ERR(tmdev->sensor[i].tzd)) return PTR_ERR(tmdev->sensor[i].tzd); - if (devm_thermal_add_hwmon_sysfs(tmdev->dev, tmdev->sensor[i].tzd)) - dev_warn(tmdev->dev, - "Failed to add hwmon sysfs attributes\n"); + devm_thermal_add_hwmon_sysfs(tmdev->dev, tmdev->sensor[i].tzd); } return 0;
The upper-layer devm_thermal_add_hwmon_sysfs() function can directly print error information. Signed-off-by: Yangtao Li <frank.li@vivo.com> --- drivers/thermal/sun8i_thermal.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)