diff mbox series

[1/2] dt-bindings: leds: Add Kinetic KTD2026/2027 LED

Message ID 20230618-ktd202x-v1-1-fc182fefadd7@apitzsch.eu
State Superseded
Headers show
Series [1/2] dt-bindings: leds: Add Kinetic KTD2026/2027 LED | expand

Commit Message

André Apitzsch June 18, 2023, 11:45 a.m. UTC 
Document Kinetic KTD2026/2027 LED driver devicetree bindings.

Signed-off-by: André Apitzsch <git@apitzsch.eu>
---
 .../devicetree/bindings/leds/leds-ktd202x.yaml     | 164 +++++++++++++++++++++
 1 file changed, 164 insertions(+)

Comments

André Apitzsch June 18, 2023, 8:28 p.m. UTC | #1 
Am Sonntag, dem 18.06.2023 um 14:41 +0200 schrieb Krzysztof Kozlowski:
> On 18/06/2023 13:45, André Apitzsch wrote:
> > Document Kinetic KTD2026/2027 LED driver devicetree bindings.
> > 
> > Signed-off-by: André Apitzsch <git@apitzsch.eu>
> > ---
> >  .../devicetree/bindings/leds/leds-ktd202x.yaml     | 164
> > +++++++++++++++++++++
> >  1 file changed, 164 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/leds/leds-
> > ktd202x.yaml b/Documentation/devicetree/bindings/leds/leds-
> > ktd202x.yaml
> > new file mode 100644
> > index 000000000000..9868d6f6f147
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/leds/leds-ktd202x.yaml
> 
> Filename matching compatible, so missing vendor prefix. Can be
> kinetic,ktd202x.yaml

Thank you for pointing this out. I'll use kinetic,ktd202x.yaml in the
next version.
> 
> > @@ -0,0 +1,164 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/leds/leds-ktd202x.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Kinetic KTD2026/7 RGB/White LED Driver
> 
> Driver stands for Linux driver or for driving a LED? If the first,
> then
> drop.
> 
It stands for driving a LED.
> 
> The rest looks good, so you just need to use proper filename.
> 
> Best regards,
> Krzysztof
> 
Best regards,
André
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/leds/leds-ktd202x.yaml b/Documentation/devicetree/bindings/leds/leds-ktd202x.yaml
new file mode 100644
index 000000000000..9868d6f6f147
--- /dev/null
+++ b/Documentation/devicetree/bindings/leds/leds-ktd202x.yaml
@@ -0,0 +1,164 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/leds/leds-ktd202x.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Kinetic KTD2026/7 RGB/White LED Driver
+
+maintainers:
+  - André Apitzsch <git@apitzsch.eu>
+
+description: |
+  The KTD2026/7 is a RGB/White LED driver with I2C interface.
+
+  The data sheet can be found at:
+    https://www.kinet-ic.com/uploads/KTD2026-7-04h.pdf
+
+properties:
+  compatible:
+    enum:
+      - kinetic,ktd2026
+      - kinetic,ktd2027
+
+  reg:
+    maxItems: 1
+
+  vin-supply:
+    description: Regulator providing power to the "VIN" pin.
+
+  "#address-cells":
+    const: 1
+
+  "#size-cells":
+    const: 0
+
+  multi-led:
+    type: object
+    $ref: leds-class-multicolor.yaml#
+    unevaluatedProperties: false
+
+    properties:
+      "#address-cells":
+        const: 1
+
+      "#size-cells":
+        const: 0
+
+    patternProperties:
+      "^led@[0-3]$":
+        type: object
+        $ref: common.yaml#
+        unevaluatedProperties: false
+
+        properties:
+          reg:
+            description: Index of the LED.
+            minimum: 0
+            maximum: 3
+
+        required:
+          - reg
+          - color
+
+    required:
+      - "#address-cells"
+      - "#size-cells"
+
+patternProperties:
+  "^led@[0-3]$":
+    type: object
+    $ref: common.yaml#
+    unevaluatedProperties: false
+
+    properties:
+      reg:
+        description: Index of the LED.
+        minimum: 0
+        maximum: 3
+
+    required:
+      - reg
+
+required:
+  - compatible
+  - reg
+  - "#address-cells"
+  - "#size-cells"
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/leds/common.h>
+
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        led-controller@30 {
+            compatible = "kinetic,ktd2026";
+            reg = <0x30>;
+            #address-cells = <1>;
+            #size-cells = <0>;
+
+            vin-supply = <&pm8916_l17>;
+
+            led@0 {
+                reg = <0>;
+                function = LED_FUNCTION_STATUS;
+                color = <LED_COLOR_ID_RED>;
+            };
+
+            led@1 {
+                reg = <1>;
+                function = LED_FUNCTION_STATUS;
+                color = <LED_COLOR_ID_GREEN>;
+            };
+
+            led@2 {
+                reg = <2>;
+                function = LED_FUNCTION_STATUS;
+                color = <LED_COLOR_ID_BLUE>;
+            };
+        };
+    };
+  - |
+    #include <dt-bindings/leds/common.h>
+
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        led-controller@30 {
+            compatible = "kinetic,ktd2026";
+            reg = <0x30>;
+            #address-cells = <1>;
+            #size-cells = <0>;
+
+            vin-supply = <&pm8916_l17>;
+
+            multi-led {
+                color = <LED_COLOR_ID_RGB>;
+                function = LED_FUNCTION_STATUS;
+
+                #address-cells = <1>;
+                #size-cells = <0>;
+
+                led@0 {
+                    reg = <0>;
+                    color = <LED_COLOR_ID_RED>;
+                };
+
+                led@1 {
+                    reg = <1>;
+                    color = <LED_COLOR_ID_GREEN>;
+                };
+
+                led@2 {
+                    reg = <2>;
+                    color = <LED_COLOR_ID_BLUE>;
+                };
+            };
+        };
+    };