diff mbox

[3/8] dmaengine: coh901318: Only calculate residue if txstate exists.

Message ID 1465321121-22238-4-git-send-email-peter.griffin@linaro.org
State Accepted
Commit 95b0aa3e10b08b9ee20b5f5e19d162d049744a9b
Headers show

Commit Message

Peter Griffin June 7, 2016, 5:38 p.m. UTC 
There is no point in calculating the residue if there is no
txstate to store the value.

Signed-off-by: Peter Griffin <peter.griffin@linaro.org>

---
 drivers/dma/coh901318.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.9.1

Comments

Linus Walleij June 8, 2016, 12:15 p.m. UTC | #1 
On Tue, Jun 7, 2016 at 7:38 PM, Peter Griffin <peter.griffin@linaro.org> wrote:

> There is no point in calculating the residue if there is no

> txstate to store the value.

>

> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>


Acked-by: Linus Walleij <linus.walleij@linaro.org>


Yours,
Linus Walleij
diff mbox

Patch

diff --git a/drivers/dma/coh901318.c b/drivers/dma/coh901318.c
index c340ca9..c100616 100644
--- a/drivers/dma/coh901318.c
+++ b/drivers/dma/coh901318.c
@@ -2422,7 +2422,7 @@  coh901318_tx_status(struct dma_chan *chan, dma_cookie_t cookie,
 	enum dma_status ret;
 
 	ret = dma_cookie_status(chan, cookie, txstate);
-	if (ret == DMA_COMPLETE)
+	if (ret == DMA_COMPLETE || !txstate)
 		return ret;
 
 	dma_set_residue(txstate, coh901318_get_bytes_left(chan));