| Message ID | 20230705093545.14695-1-duminjie@vivo.com |
|---|---|
| State | Accepted |
| Commit | 983b9180db96255183c30f69fe43c0db75bf8502 |
| Headers | show |
| Series | [v2] sound: seq: fix typo in system_2p_ev_to_ump_midi1() | expand |
On Wed, 05 Jul 2023 11:35:45 +0200, Minjie Du wrote: > > Fix data->system.parm2 typo. > > Signed-off-by: Minjie Du <duminjie@vivo.com> Thanks, applied now. At the next time, though, it'd be appreciated if you give the corresponding Fixes tag, too. I added manually for now. Takashi
> At the next time, though, it'd be appreciated if you give the corresponding Fixes tag, too. Sorry it was my mistake, thanks -----邮件原件----- 发件人: Takashi Iwai <tiwai@suse.de> 发送时间: 2023年7月5日 17:53 收件人: 杜敏杰 <duminjie@vivo.com> 抄送: Jaroslav Kysela <perex@perex.cz>; Takashi Iwai <tiwai@suse.com>; Stephen Rothwell <sfr@canb.auug.org.au>; moderated list:SOUND <alsa-devel@alsa-project.org>; open list <linux-kernel@vger.kernel.org>; opensource.kernel <opensource.kernel@vivo.com> 主题: Re: [PATCH v2] sound: seq: fix typo in system_2p_ev_to_ump_midi1() [Some people who received this message don't often get email from tiwai@suse.de. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] On Wed, 05 Jul 2023 11:35:45 +0200, Minjie Du wrote: > > Fix data->system.parm2 typo. > > Signed-off-by: Minjie Du <duminjie@vivo.com> Thanks, applied now. At the next time, though, it'd be appreciated if you give the corresponding Fixes tag, too. I added manually for now. Takashi
diff --git a/sound/core/seq/seq_ump_convert.c b/sound/core/seq/seq_ump_convert.c index eb1d86ff6..7cc84e137 100644 --- a/sound/core/seq/seq_ump_convert.c +++ b/sound/core/seq/seq_ump_convert.c @@ -714,7 +714,7 @@ static int system_2p_ev_to_ump_midi1(const struct snd_seq_event *event, { data->system.status = status; data->system.parm1 = (event->data.control.value >> 7) & 0x7f; - data->system.parm1 = event->data.control.value & 0x7f; + data->system.parm2 = event->data.control.value & 0x7f; return 1; }
Fix data->system.parm2 typo. Signed-off-by: Minjie Du <duminjie@vivo.com> --- sound/core/seq/seq_ump_convert.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)