| Message ID | 20230708072835.3035398-6-quic_jprakash@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | iio: adc: Add support for QCOM SPMI PMIC5 Gen3 ADC | expand |
Hi Krzysztof, On 7/9/2023 11:08 PM, Krzysztof Kozlowski wrote: > On 08/07/2023 09:28, Jishnu Prakash wrote: >> Now that usage of "ADC7" name has been replaced with usage of "ADC5 >> Gen2" name everywhere, remove the "qcom,spmi-adc7" compatible string. >> >> Signed-off-by: Jishnu Prakash <quic_jprakash@quicinc.com> >> --- >> drivers/iio/adc/qcom-spmi-adc5.c | 4 ---- > Your patchset is not bisectable. Neither this patch nor cover letter > marked this. This is not correct and will lead to broken kernels. > > Even if not considering bisectability, this basically breaks the ABI > without any explanation and rationale. > > Breaking ABI just because you want to rename something, is not the way > to go, so NAK. Sorry. > > Best regards, > Krzysztof I'll drop this patch and just mark the older name as deprecated. For concerns on bisectability, I have asked some questions in my other replies for this patch series, I'll structure my next patchsets according to the replies I get. Thanks, Jishnu >
diff --git a/drivers/iio/adc/qcom-spmi-adc5.c b/drivers/iio/adc/qcom-spmi-adc5.c index 3ac1ee500a67..6cebeaa69a75 100644 --- a/drivers/iio/adc/qcom-spmi-adc5.c +++ b/drivers/iio/adc/qcom-spmi-adc5.c @@ -807,10 +807,6 @@ static const struct of_device_id adc5_match_table[] = { .compatible = "qcom,spmi-adc5", .data = &adc5_data_pmic, }, - { - .compatible = "qcom,spmi-adc7", - .data = &adc5_gen2_data_pmic, - }, { .compatible = "qcom,spmi-adc5-gen2", .data = &adc5_gen2_data_pmic,
Now that usage of "ADC7" name has been replaced with usage of "ADC5 Gen2" name everywhere, remove the "qcom,spmi-adc7" compatible string. Signed-off-by: Jishnu Prakash <quic_jprakash@quicinc.com> --- drivers/iio/adc/qcom-spmi-adc5.c | 4 ---- 1 file changed, 4 deletions(-)