| Message ID | e521a8d35e8baff45db1fdf8a26725bdc8d595ee.1689196901.git.pav@iki.fi |
|---|---|
| State | New |
| Headers | show |
| Series | [BlueZ,v2,1/2] test-runner: set non-quiet printk before running tests | expand |
Hello: This series was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Thu, 13 Jul 2023 00:22:48 +0300 you wrote: > It is useful to see WARN_ON etc. messages when running the tests. > > The 'quiet' in cmdline suppresses levels >= WARN, so re-enable them > explicitly after boot, so that it is on by default and doesn't need to > be handled in local test scripts. > --- > > [...] Here is the summary with links: - [BlueZ,v2,1/2] test-runner: set non-quiet printk before running tests https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=7cea6b964119 - [BlueZ,v2,2/2] test-runner: fix behavior when no audio server https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=9aff3f494142 You are awesome, thank you!
diff --git a/tools/test-runner.c b/tools/test-runner.c index d74bb1087..119e1cfbc 100644 --- a/tools/test-runner.c +++ b/tools/test-runner.c @@ -136,6 +136,24 @@ static const char *config_table[] = { NULL }; +static void enable_printk(void) +{ + FILE *f; + + f = fopen("/proc/sys/kernel/printk", "w"); + if (!f) { + perror("Failed to set printk"); + return; + } + + /* Restore printk loglevel, undoing 'quiet' in cmdline (suppress early + * on-boot messages), to show WARN_ON etc. Suppress level>=6(INFO), set + * default_msg:4(WARN) & min:1, default:7. See man 2 syslog. + */ + fprintf(f, "6 4 1 7"); + fclose(f); +} + static void prepare_sandbox(void) { int i; @@ -181,6 +199,8 @@ static void prepare_sandbox(void) "mode=0755") < 0) perror("Failed to create filesystem"); } + + enable_printk(); } static char *const qemu_argv[] = {
It is useful to see WARN_ON etc. messages when running the tests. The 'quiet' in cmdline suppresses levels >= WARN, so re-enable them explicitly after boot, so that it is on by default and doesn't need to be handled in local test scripts. --- Notes: v2: add comment. Suppress level>=INFO, to hide "Bluetooth: MGMT ver" etc. It could be useful to also check for BUG/WARNING in the bluez test bot. tools/test-runner.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)