diff mbox series

[V2,1/2] dt-bindings: arm: qcom,ids: drop the IPQ5019 SoC ID

Message ID 20230712041912.398724-2-quic_kathirav@quicinc.com
State New
Headers show
Series Drop the IPQ5019 SoC ID | expand

Commit Message

Kathiravan Thirumoorthy July 12, 2023, 4:19 a.m. UTC
IPQ5019 SoC is never productized. So lets drop it.

Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
---
Changes in V2:
	- Updated the commit message with the precise information for
	  dropping this ID

 include/dt-bindings/arm/qcom,ids.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Rob Herring (Arm) July 14, 2023, 3:59 p.m. UTC | #1
On Wed, Jul 12, 2023 at 09:49:11AM +0530, Kathiravan T wrote:
> IPQ5019 SoC is never productized. So lets drop it.

You need to remove the user before removing the definition.

> 
> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
> ---
> Changes in V2:
> 	- Updated the commit message with the precise information for
> 	  dropping this ID
> 
>  include/dt-bindings/arm/qcom,ids.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h
> index bcbe9ee2cdaf..179dd56b2d95 100644
> --- a/include/dt-bindings/arm/qcom,ids.h
> +++ b/include/dt-bindings/arm/qcom,ids.h
> @@ -250,7 +250,6 @@
>  #define QCOM_ID_QRU1000			539
>  #define QCOM_ID_QDU1000			545
>  #define QCOM_ID_QDU1010			587
> -#define QCOM_ID_IPQ5019			569
>  #define QCOM_ID_QRU1032			588
>  #define QCOM_ID_QRU1052			589
>  #define QCOM_ID_QRU1062			590
> -- 
> 2.34.1
>
Bjorn Andersson July 22, 2023, 4:02 a.m. UTC | #2
On Sat, Jul 15, 2023 at 08:41:56PM +0530, Kathiravan T wrote:
> 
> On 7/14/2023 9:29 PM, Rob Herring wrote:
> > On Wed, Jul 12, 2023 at 09:49:11AM +0530, Kathiravan T wrote:
> > > IPQ5019 SoC is never productized. So lets drop it.
> > You need to remove the user before removing the definition.
> 
> Rob, Currently there are no users for this macro.
> 

But you're removing a user in patch 2? Or am I reading that incorrectly?

Regards,
Bjorn
diff mbox series

Patch

diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h
index bcbe9ee2cdaf..179dd56b2d95 100644
--- a/include/dt-bindings/arm/qcom,ids.h
+++ b/include/dt-bindings/arm/qcom,ids.h
@@ -250,7 +250,6 @@ 
 #define QCOM_ID_QRU1000			539
 #define QCOM_ID_QDU1000			545
 #define QCOM_ID_QDU1010			587
-#define QCOM_ID_IPQ5019			569
 #define QCOM_ID_QRU1032			588
 #define QCOM_ID_QRU1052			589
 #define QCOM_ID_QRU1062			590