[v2,09/10] qla2xxx: fix inconsistent TMF timeout

Message ID	20230714070104.40052-10-njavali@marvell.com
State	New
Headers	show Return-Path: <linux-scsi-owner@vger.kernel.org> From: Nilesh Javali <njavali@marvell.com> To: <martin.petersen@oracle.com> CC: <linux-scsi@vger.kernel.org>, <GR-QLogic-Storage-Upstream@marvell.com>, <agurumurthy@marvell.com>, <sdeodhar@marvell.com> Subject: [PATCH v2 09/10] qla2xxx: fix inconsistent TMF timeout Date: Fri, 14 Jul 2023 12:31:03 +0530 Message-ID: <20230714070104.40052-10-njavali@marvell.com> In-Reply-To: <20230714070104.40052-1-njavali@marvell.com> References: <20230714070104.40052-1-njavali@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Precedence: bulk
Series	qla2xxx driver bug fixes \| expand [v2,00/10] qla2xxx driver bug fixes [v2,01/10] qla2xxx: Fix deletion race condition [v2,02/10] qla2xxx: Adjust iocb resource on qpair create [v2,03/10] qla2xxx: Limit TMF to 8 per function [v2,04/10] qla2xxx: Fix command flush during TMF [v2,05/10] qla2xxx: Fix erroneous link up failure [v2,06/10] qla2xxx: Fix session hang in gnl [v2,07/10] qla2xxx: Turn off noisy message log [v2,08/10] qla2xxx: Fix TMF leak through [v2,09/10] qla2xxx: fix inconsistent TMF timeout [v2,10/10] qla2xxx: Update version to 10.02.08.500-k

Message ID

20230714070104.40052-10-njavali@marvell.com

State

New

Headers

From: Nilesh Javali <njavali@marvell.com>
To: <martin.petersen@oracle.com>
CC: <linux-scsi@vger.kernel.org>,
        <GR-QLogic-Storage-Upstream@marvell.com>,
        <agurumurthy@marvell.com>, <sdeodhar@marvell.com>
Subject: [PATCH v2 09/10] qla2xxx: fix inconsistent TMF timeout
Date: Fri, 14 Jul 2023 12:31:03 +0530
Message-ID: <20230714070104.40052-10-njavali@marvell.com>
In-Reply-To: <20230714070104.40052-1-njavali@marvell.com>
References: <20230714070104.40052-1-njavali@marvell.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk

Series

qla2xxx driver bug fixes | expand

Commit Message

Nilesh Javali July 14, 2023, 7:01 a.m. UTC

From: Quinn Tran <qutran@marvell.com>

Different behavior were experienced of session being
torn down vs not, when TMF is timed out. When FW detects
the time out, the session is torn down.  When driver detects
the time out, the session is not torn down.

Allow TMF error to return to upper layer without session
tear down.

Cc: stable@vger.kernel.org
Signed-off-by: Quinn Tran <qutran@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
---
 drivers/scsi/qla2xxx/qla_isr.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
index eb8480a0d7b0..aba39127474a 100644
--- a/drivers/scsi/qla2xxx/qla_isr.c
+++ b/drivers/scsi/qla2xxx/qla_isr.c
@@ -2543,7 +2543,6 @@  qla24xx_tm_iocb_entry(scsi_qla_host_t *vha, struct req_que *req, void *tsk)
 	case CS_PORT_BUSY:
 	case CS_INCOMPLETE:
 	case CS_PORT_UNAVAILABLE:
-	case CS_TIMEOUT:
 	case CS_RESET:
 		if (atomic_read(&fcport->state) == FCS_ONLINE) {
 			ql_dbg(ql_dbg_disc, fcport->vha, 0x3021,

[v2,09/10] qla2xxx: fix inconsistent TMF timeout

Commit Message

Patch