diff mbox series

taging: fbtft: Add space around '='

Message ID a8b204f8562cb5d4ad837f6df0c14b74@208suo.com
State New
Headers show
Series taging: fbtft: Add space around '=' | expand

Commit Message

hanyu001@208suo.com July 17, 2023, 8:15 a.m. UTC
Fix checkpatch warnings:

./drivers/staging/media/av7110/dvb_filter.c:105: ERROR: spaces required 
around that '=' (ctx:VxV)
./drivers/staging/media/av7110/dvb_filter.c:106: ERROR: spaces required 
around that '=' (ctx:VxV)
./drivers/staging/media/av7110/dvb_filter.c:108: ERROR: spaces required 
around that '=' (ctx:VxV)
./drivers/staging/media/av7110/dvb_filter.c:112: ERROR: spaces required 
around that '=' (ctx:VxV)

Signed-off-by: maqimei <2433033762@qq.com>
---
  drivers/staging/media/av7110/dvb_filter.c | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)

  }

Comments

Ping-Ke Shih July 18, 2023, 12:29 a.m. UTC | #1
> -----Original Message-----
> From: hanyu001@208suo.com <hanyu001@208suo.com>
> Sent: Monday, July 17, 2023 4:16 PM
> To: toke@toke.dk; kvalo@kernel.org
> Cc: linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] taging: fbtft: Add space around '='
> 
> Fix checkpatch warnings:
> 
> ./drivers/staging/media/av7110/dvb_filter.c:105: ERROR: spaces required
> around that '=' (ctx:VxV)
> ./drivers/staging/media/av7110/dvb_filter.c:106: ERROR: spaces required
> around that '=' (ctx:VxV)
> ./drivers/staging/media/av7110/dvb_filter.c:108: ERROR: spaces required
> around that '=' (ctx:VxV)
> ./drivers/staging/media/av7110/dvb_filter.c:112: ERROR: spaces required
> around that '=' (ctx:VxV)
> 
> Signed-off-by: maqimei <2433033762@qq.com>
> ---
>   drivers/staging/media/av7110/dvb_filter.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/media/av7110/dvb_filter.c
> b/drivers/staging/media/av7110/dvb_filter.c
> index 8c2eca5..014fa1f 100644
> --- a/drivers/staging/media/av7110/dvb_filter.c
> +++ b/drivers/staging/media/av7110/dvb_filter.c
> @@ -102,14 +102,14 @@ int dvb_filter_pes2ts(struct dvb_filter_pes2ts
> *p2ts, unsigned char *pes,
>       }
>       if (!len)
>           return 0;
> -    buf[3]=0x30|((p2ts->cc++)&0x0f);
> -    rest=183-len;
> +    buf[3] = 0x30|((p2ts->cc++)&0x0f);
> +    rest = 183-len;

Adding spaces around operators | and & would look better:
  buf[3] = 0x30 | ((p2ts->cc++) & 0x0f);
  rest = 183 - len;
diff mbox series

Patch

diff --git a/drivers/staging/media/av7110/dvb_filter.c 
b/drivers/staging/media/av7110/dvb_filter.c
index 8c2eca5..014fa1f 100644
--- a/drivers/staging/media/av7110/dvb_filter.c
+++ b/drivers/staging/media/av7110/dvb_filter.c
@@ -102,14 +102,14 @@  int dvb_filter_pes2ts(struct dvb_filter_pes2ts 
*p2ts, unsigned char *pes,
      }
      if (!len)
          return 0;
-    buf[3]=0x30|((p2ts->cc++)&0x0f);
-    rest=183-len;
+    buf[3] = 0x30|((p2ts->cc++)&0x0f);
+    rest = 183-len;
      if (rest) {
-        buf[5]=0x00;
+        buf[5] = 0x00;
          if (rest-1)
              memset(buf+6, 0xff, rest-1);
      }
-    buf[4]=rest;
+    buf[4] = rest;
      memcpy(buf+5+rest, pes, len);
      return p2ts->cb(p2ts->priv, buf);