diff mbox series

libertas: debugfs: Added missing spaces

Message ID 013fa54eeb505b6a7080c6d4ccc3a445@208suo.com
State New
Headers show
Series libertas: debugfs: Added missing spaces | expand

Commit Message

hanyu001@208suo.com July 19, 2023, 9:31 a.m. UTC
Fixes the following checkpatch errors:

./drivers/net/wireless/marvell/libertas/debugfs.c:712: ERROR: spaces 
required around that '=' (ctx:VxV)
./drivers/net/wireless/marvell/libertas/debugfs.c:712: ERROR: spaces 
required around that '<' (ctx:VxV)
./drivers/net/wireless/marvell/libertas/debugfs.c:723: ERROR: spaces 
required around that '=' (ctx:VxV)
./drivers/net/wireless/marvell/libertas/debugfs.c:723: ERROR: spaces 
required around that '<' (ctx:VxV)
./drivers/net/wireless/marvell/libertas/debugfs.c:734: ERROR: spaces 
required around that '=' (ctx:VxV)
./drivers/net/wireless/marvell/libertas/debugfs.c:734: ERROR: spaces 
required around that '<' (ctx:VxV)
./drivers/net/wireless/marvell/libertas/debugfs.c:754: ERROR: spaces 
required around that '=' (ctx:VxV)
./drivers/net/wireless/marvell/libertas/debugfs.c:754: ERROR: spaces 
required around that '<' (ctx:VxV)
./drivers/net/wireless/marvell/libertas/debugfs.c:754: ERROR: space 
required before the open parenthesis '('
./drivers/net/wireless/marvell/libertas/debugfs.c:759: ERROR: spaces 
required around that '=' (ctx:VxV)
./drivers/net/wireless/marvell/libertas/debugfs.c:759: ERROR: spaces 
required around that '<' (ctx:VxV)
./drivers/net/wireless/marvell/libertas/debugfs.c:759: ERROR: space 
required before the open parenthesis '('
./drivers/net/wireless/marvell/libertas/debugfs.c:766: ERROR: spaces 
required around that '=' (ctx:VxV)
./drivers/net/wireless/marvell/libertas/debugfs.c:766: ERROR: spaces 
required around that '<' (ctx:VxV)
./drivers/net/wireless/marvell/libertas/debugfs.c:766: ERROR: space 
required before the open parenthesis '('

Signed-off-by: Yu Han <hanyu001@208suo.com>
---
  drivers/net/wireless/marvell/libertas/debugfs.c | 12 ++++++------
  1 file changed, 6 insertions(+), 6 deletions(-)

                                   files->perm,
@@ -720,7 +720,7 @@ void lbs_debugfs_init_one(struct lbs_private *priv, 
struct net_device *dev)

      priv->events_dir = debugfs_create_dir("subscribed_events", 
priv->debugfs_dir);

-    for (i=0; i<ARRAY_SIZE(debugfs_events_files); i++) {
+    for (i = 0; i < ARRAY_SIZE(debugfs_events_files); i++) {
          files = &debugfs_events_files[i];
          priv->debugfs_events_files[i] = 
debugfs_create_file(files->name,
                                   files->perm,
@@ -731,7 +731,7 @@ void lbs_debugfs_init_one(struct lbs_private *priv, 
struct net_device *dev)

      priv->regs_dir = debugfs_create_dir("registers", 
priv->debugfs_dir);

-    for (i=0; i<ARRAY_SIZE(debugfs_regs_files); i++) {
+    for (i = 0; i < ARRAY_SIZE(debugfs_regs_files); i++) {
          files = &debugfs_regs_files[i];
          priv->debugfs_regs_files[i] = debugfs_create_file(files->name,
                                   files->perm,
@@ -751,19 +751,19 @@ void lbs_debugfs_remove_one(struct lbs_private 
*priv)
  {
      int i;

-    for(i=0; i<ARRAY_SIZE(debugfs_regs_files); i++)
+    for (i = 0; i < ARRAY_SIZE(debugfs_regs_files); i++)
          debugfs_remove(priv->debugfs_regs_files[i]);

      debugfs_remove(priv->regs_dir);

-    for(i=0; i<ARRAY_SIZE(debugfs_events_files); i++)
+    for (i = 0; i < ARRAY_SIZE(debugfs_events_files); i++)
          debugfs_remove(priv->debugfs_events_files[i]);

      debugfs_remove(priv->events_dir);
  #ifdef PROC_DEBUG
      debugfs_remove(priv->debugfs_debug);
  #endif
-    for(i=0; i<ARRAY_SIZE(debugfs_files); i++)
+    for (i = 0; i < ARRAY_SIZE(debugfs_files); i++)
          debugfs_remove(priv->debugfs_files[i]);
      debugfs_remove(priv->debugfs_dir);
  }

Comments

Kalle Valo July 24, 2023, 2:26 p.m. UTC | #1
hanyu001@208suo.com writes:

> Fixes the following checkpatch errors:
>
> ./drivers/net/wireless/marvell/libertas/debugfs.c:712: ERROR: spaces
> required around that '=' (ctx:VxV)
> ./drivers/net/wireless/marvell/libertas/debugfs.c:712: ERROR: spaces
> required around that '<' (ctx:VxV)
> ./drivers/net/wireless/marvell/libertas/debugfs.c:723: ERROR: spaces
> required around that '=' (ctx:VxV)
> ./drivers/net/wireless/marvell/libertas/debugfs.c:723: ERROR: spaces
> required around that '<' (ctx:VxV)
> ./drivers/net/wireless/marvell/libertas/debugfs.c:734: ERROR: spaces
> required around that '=' (ctx:VxV)
> ./drivers/net/wireless/marvell/libertas/debugfs.c:734: ERROR: spaces
> required around that '<' (ctx:VxV)
> ./drivers/net/wireless/marvell/libertas/debugfs.c:754: ERROR: spaces
> required around that '=' (ctx:VxV)
> ./drivers/net/wireless/marvell/libertas/debugfs.c:754: ERROR: spaces
> required around that '<' (ctx:VxV)
> ./drivers/net/wireless/marvell/libertas/debugfs.c:754: ERROR: space
> required before the open parenthesis '('
> ./drivers/net/wireless/marvell/libertas/debugfs.c:759: ERROR: spaces
> required around that '=' (ctx:VxV)
> ./drivers/net/wireless/marvell/libertas/debugfs.c:759: ERROR: spaces
> required around that '<' (ctx:VxV)
> ./drivers/net/wireless/marvell/libertas/debugfs.c:759: ERROR: space
> required before the open parenthesis '('
> ./drivers/net/wireless/marvell/libertas/debugfs.c:766: ERROR: spaces
> required around that '=' (ctx:VxV)
> ./drivers/net/wireless/marvell/libertas/debugfs.c:766: ERROR: spaces
> required around that '<' (ctx:VxV)
> ./drivers/net/wireless/marvell/libertas/debugfs.c:766: ERROR: space
> required before the open parenthesis '('
>
> Signed-off-by: Yu Han <hanyu001@208suo.com>

Please don't submit checkpatch fixes to linux-wireless, they are too
much work with very little gain. And libertas is an orphaned driver, we
want to make the absolute minimal changes to it.

I'm now going to silently reject all checkpatch patches in patchwork.
diff mbox series

Patch

diff --git a/drivers/net/wireless/marvell/libertas/debugfs.c 
b/drivers/net/wireless/marvell/libertas/debugfs.c
index c604613..8939bf4 100644
--- a/drivers/net/wireless/marvell/libertas/debugfs.c
+++ b/drivers/net/wireless/marvell/libertas/debugfs.c
@@ -709,7 +709,7 @@  void lbs_debugfs_init_one(struct lbs_private *priv, 
struct net_device *dev)

      priv->debugfs_dir = debugfs_create_dir(dev->name, lbs_dir);

-    for (i=0; i<ARRAY_SIZE(debugfs_files); i++) {
+    for (i = 0; i < ARRAY_SIZE(debugfs_files); i++) {
          files = &debugfs_files[i];
          priv->debugfs_files[i] = debugfs_create_file(files->name,