diff mbox series

[1/4] arm64: dts: qcom: sc8180x-pmics: add missing qcom,spmi-gpio fallbacks

Message ID 20230720083500.73554-1-krzysztof.kozlowski@linaro.org
State Accepted
Commit 0304fc1de3d930db83749cca6ccb3a4f89918fc4
Headers show
Series [1/4] arm64: dts: qcom: sc8180x-pmics: add missing qcom,spmi-gpio fallbacks | expand

Commit Message

Krzysztof Kozlowski July 20, 2023, 8:34 a.m. UTC
The GPIO children of PMICs should use qcom,spmi-gpio fallback:

  sc8180x-primus.dtb: pmic@0: gpio@c000:compatible: ['qcom,pmc8180-gpio'] is too short

Fixes: d3302290f59e ("arm64: dts: qcom: sc8180x: Add pmics")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Konrad Dybcio July 20, 2023, 8:36 a.m. UTC | #1
On 20.07.2023 10:34, Krzysztof Kozlowski wrote:
> The GPIO children of PMICs should use qcom,spmi-gpio fallback:
> 
>   sc8180x-primus.dtb: pmic@0: gpio@c000:compatible: ['qcom,pmc8180-gpio'] is too short
> 
> Fixes: d3302290f59e ("arm64: dts: qcom: sc8180x: Add pmics")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
Bjorn Andersson July 22, 2023, 5:17 a.m. UTC | #2
On Thu, 20 Jul 2023 10:34:57 +0200, Krzysztof Kozlowski wrote:
> The GPIO children of PMICs should use qcom,spmi-gpio fallback:
> 
>   sc8180x-primus.dtb: pmic@0: gpio@c000:compatible: ['qcom,pmc8180-gpio'] is too short
> 
> 

Applied, thanks!

[1/4] arm64: dts: qcom: sc8180x-pmics: add missing qcom,spmi-gpio fallbacks
      commit: 0304fc1de3d930db83749cca6ccb3a4f89918fc4
[2/4] arm64: dts: qcom: sc8180x-pmics: add missing gpio-ranges
      commit: 565951b1202e1984154abaae4567f16f8073fca3
[3/4] arm64: dts: qcom: sc8180x-pmics: align SPMI PMIC Power-on node name with dtschema
      commit: bf520227bd32381c587fa36271475e035daab3d7
[4/4] arm64: dts: qcom: sc8180x-pmics: align LPG node name with dtschema
      commit: 4af302a7e29e70bd930e80ab8f967da48a99a31a

Best regards,
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi b/arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi
index 4556af6cd103..ef2f8b732833 100644
--- a/arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi
@@ -142,7 +142,7 @@  rtc@6000 {
 		};
 
 		pmc8180_gpios: gpio@c000 {
-			compatible = "qcom,pmc8180-gpio";
+			compatible = "qcom,pmc8180-gpio", "qcom,spmi-gpio";
 			reg = <0xc000>;
 			gpio-controller;
 			#gpio-cells = <2>;
@@ -300,7 +300,7 @@  pmc8180c_adc_tm: adc-tm@3500 {
 		};
 
 		pmc8180c_gpios: gpio@c000 {
-			compatible = "qcom,pmc8180c-gpio";
+			compatible = "qcom,pmc8180c-gpio", "qcom,spmi-gpio";
 			reg = <0xc000>;
 			gpio-controller;
 			#gpio-cells = <2>;