| Message ID | SY7P282MB378740C6070900BEBF5D0D7CB203A@SY7P282MB3787.AUSP282.PROD.OUTLOOK.COM |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [V2] arm64: dts: qcom: sm8150: Fix the I2C7 interrupt | expand |
On 25/07/2023 10:42, qaz6750 lzy wrote: > I2C6 and I2C7 use the same interrupts, which is incorrect. > In the downstream kernel, I2C7 has interrupts of 608 instead of 607. > > Fixes: 81bee6953b58 ("arm64: dts: qcom: sm8150: add i2c nodes") > Signed-off-by: qaz6750 lzy <qaz6750@outlook.com> > --- > [v2] Fixed issue of not using full name You mentioned your full name as a bit different, so I am not sure what improved here. Best regards, Krzysztof
On 26.07.2023 20:46, Krzysztof Kozlowski wrote: > On 25/07/2023 10:42, qaz6750 lzy wrote: >> I2C6 and I2C7 use the same interrupts, which is incorrect. >> In the downstream kernel, I2C7 has interrupts of 608 instead of 607. >> >> Fixes: 81bee6953b58 ("arm64: dts: qcom: sm8150: add i2c nodes") >> Signed-off-by: qaz6750 lzy <qaz6750@outlook.com> >> --- >> [v2] Fixed issue of not using full name > > You mentioned your full name as a bit different, so I am not sure what > improved here. To be clear: "real name" usually means "the name that is present on your government-issued ID card. Konrad
On Wed, 26 Jul 2023 at 21:47, Konrad Dybcio <konrad.dybcio@linaro.org> wrote: > > On 26.07.2023 20:46, Krzysztof Kozlowski wrote: > > On 25/07/2023 10:42, qaz6750 lzy wrote: > >> I2C6 and I2C7 use the same interrupts, which is incorrect. > >> In the downstream kernel, I2C7 has interrupts of 608 instead of 607. > >> > >> Fixes: 81bee6953b58 ("arm64: dts: qcom: sm8150: add i2c nodes") > >> Signed-off-by: qaz6750 lzy <qaz6750@outlook.com> > >> --- > >> [v2] Fixed issue of not using full name > > > > You mentioned your full name as a bit different, so I am not sure what > > improved here. > To be clear: "real name" usually means "the name that is present on your > government-issued ID card. Or at least some kind of a 'full name', not the nickname or a random set of characters. The same name should be a part of the 'From' and 'Signed-off-by' tags.
diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi index 837bdb574743..560b758b0a06 100644 --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi @@ -1231,7 +1231,7 @@ i2c7: i2c@89c000 { dma-names = "tx", "rx"; pinctrl-names = "default"; pinctrl-0 = <&qup_i2c7_default>; - interrupts = <GIC_SPI 607 IRQ_TYPE_LEVEL_HIGH>; + interrupts = <GIC_SPI 608 IRQ_TYPE_LEVEL_HIGH>; #address-cells = <1>; #size-cells = <0>; status = "disabled";
I2C6 and I2C7 use the same interrupts, which is incorrect. In the downstream kernel, I2C7 has interrupts of 608 instead of 607. Fixes: 81bee6953b58 ("arm64: dts: qcom: sm8150: add i2c nodes") Signed-off-by: qaz6750 lzy <qaz6750@outlook.com> --- [v2] Fixed issue of not using full name arch/arm64/boot/dts/qcom/sm8150.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)