| Message ID | 1466714368-4813-3-git-send-email-john.stultz@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
Hi John, On 23/06/2016 21:39, John Stultz wrote: > From: Zhangfei Gao <zhangfei.gao@linaro.org> > > Add pl031 rtc0 and rtc1 support to hi6220 dtsi > > Cc: Michael Turquette <mturquette@baylibre.com> > Cc: Stephen Boyd <sboyd@codeaurora.org> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Pawel Moll <pawel.moll@arm.com> > Cc: Wei Xu <xuwei5@hisilicon.com> > Cc: Guodong Xu <guodong.xu@linaro.org> > Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org> > [jstultz: Forward ported and tweaked commit description, > added rtc1 entry as suggested by Guodong] > Signed-off-by: John Stultz <john.stultz@linaro.org> > --- > arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi > index 189d215..12510b5 100644 > --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi > +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi > @@ -336,6 +336,22 @@ > clock-names = "timer1", "timer2", "apb_pclk"; > }; > > + rtc0: rtc@f8003000 { > + compatible = "arm,pl031", "arm,primecell"; > + reg = <0x0 0xf8003000 0x0 0x1000>; > + interrupts = <0 12 4>; > + clocks = <&ao_ctrl HI6220_RTC0_PCLK>; > + clock-names = "apb_pclk"; > + }; > + > + rtc1: rtc@f8004000 { Sorry for the late reply. Thanks for the patch! Except the indent of the rtc1, the others is fine to me. Acked-by: Wei Xu <xuwei5@hisilicon.com> As what Stephen said in the cover letter works for me. Best Regards, Wei > + compatible = "arm,pl031", "arm,primecell"; > + reg = <0x0 0xf8004000 0x0 0x1000>; > + interrupts = <0 8 4>; > + clocks = <&ao_ctrl HI6220_RTC1_PCLK>; > + clock-names = "apb_pclk"; > + }; > + > pmx0: pinmux@f7010000 { > compatible = "pinctrl-single"; > reg = <0x0 0xf7010000 0x0 0x27c>; >
diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi index 189d215..12510b5 100644 --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi @@ -336,6 +336,22 @@ clock-names = "timer1", "timer2", "apb_pclk"; }; + rtc0: rtc@f8003000 { + compatible = "arm,pl031", "arm,primecell"; + reg = <0x0 0xf8003000 0x0 0x1000>; + interrupts = <0 12 4>; + clocks = <&ao_ctrl HI6220_RTC0_PCLK>; + clock-names = "apb_pclk"; + }; + + rtc1: rtc@f8004000 { + compatible = "arm,pl031", "arm,primecell"; + reg = <0x0 0xf8004000 0x0 0x1000>; + interrupts = <0 8 4>; + clocks = <&ao_ctrl HI6220_RTC1_PCLK>; + clock-names = "apb_pclk"; + }; + pmx0: pinmux@f7010000 { compatible = "pinctrl-single"; reg = <0x0 0xf7010000 0x0 0x27c>;