| Message ID | 20230727110558.2904084-1-ruanjinjie@huawei.com |
|---|---|
| State | Accepted |
| Commit | b505e2ecf31b6a2a62c76203558384d7646ab02f |
| Headers | show |
| Series | [-next] spi: stm32: Remove redundant dev_err_probe() | expand |
diff --git a/drivers/spi/spi-stm32.c b/drivers/spi/spi-stm32.c index 8cf7b41481b2..d16ee6e54de9 100644 --- a/drivers/spi/spi-stm32.c +++ b/drivers/spi/spi-stm32.c @@ -1836,8 +1836,7 @@ static int stm32_spi_probe(struct platform_device *pdev) spi->irq = platform_get_irq(pdev, 0); if (spi->irq <= 0) - return dev_err_probe(&pdev->dev, spi->irq, - "failed to get irq\n"); + return spi->irq; ret = devm_request_threaded_irq(&pdev->dev, spi->irq, spi->cfg->irq_handler_event,
There is no need to call the dev_err_probe() function directly to print a custom message when handling an error from platform_get_irq() function as it is going to display an appropriate error message in case of a failure. Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com> --- drivers/spi/spi-stm32.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)