diff mbox series

gpio: zevio: remove unneeded call to platform_set_drvdata()

Message ID 20230801204606.9738-1-aboutphysycs@gmail.com
State Accepted
Commit 146bf98e00886420199d8892d3684c9736789b0c
Headers show
Series gpio: zevio: remove unneeded call to platform_set_drvdata() | expand

Commit Message

Andrei Coardos Aug. 1, 2023, 8:46 p.m. UTC 
This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata() call to access the private data of the driver. Also,
the private data is defined in this driver, so there is no risk of it being
accessed outside of this driver file.

Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
---
 drivers/gpio/gpio-zevio.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Andy Shevchenko Aug. 2, 2023, 3:25 a.m. UTC | #1 
On Tue, Aug 01, 2023 at 11:46:06PM +0300, Andrei Coardos wrote:
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.

Reviewed-by: Andy Shevchenko <andy@kernel.org>
Bartosz Golaszewski Aug. 3, 2023, 1:49 p.m. UTC | #2 
On Tue, Aug 1, 2023 at 10:46 PM Andrei Coardos <aboutphysycs@gmail.com> wrote:
>
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
>
> Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
> ---
>  drivers/gpio/gpio-zevio.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-zevio.c b/drivers/gpio/gpio-zevio.c
> index f0f571b323f2..2de61337ad3b 100644
> --- a/drivers/gpio/gpio-zevio.c
> +++ b/drivers/gpio/gpio-zevio.c
> @@ -176,8 +176,6 @@ static int zevio_gpio_probe(struct platform_device *pdev)
>         if (!controller)
>                 return -ENOMEM;
>
> -       platform_set_drvdata(pdev, controller);
> -
>         /* Copy our reference */
>         controller->chip = zevio_gpio_chip;
>         controller->chip.parent = &pdev->dev;
> --
> 2.34.1
>

Applied, thanks!

Bart
diff mbox series

Patch

diff --git a/drivers/gpio/gpio-zevio.c b/drivers/gpio/gpio-zevio.c
index f0f571b323f2..2de61337ad3b 100644
--- a/drivers/gpio/gpio-zevio.c
+++ b/drivers/gpio/gpio-zevio.c
@@ -176,8 +176,6 @@  static int zevio_gpio_probe(struct platform_device *pdev)
 	if (!controller)
 		return -ENOMEM;
 
-	platform_set_drvdata(pdev, controller);
-
 	/* Copy our reference */
 	controller->chip = zevio_gpio_chip;
 	controller->chip.parent = &pdev->dev;