diff mbox series

gpio: timberdale: remove unneeded call to platform_set_drvdata()

Message ID 20230801073211.4274-1-aboutphysycs@gmail.com
State Accepted
Commit 02840579a94da4fb73292464c34c47222050923d
Headers show
Series gpio: timberdale: remove unneeded call to platform_set_drvdata() | expand

Commit Message

Andrei Coardos Aug. 1, 2023, 7:32 a.m. UTC 
This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata() call to access the private data of the driver. Also,
the private data is defined in this driver, so there is no risk of it being
accessed outside of this driver file.

Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
---
 drivers/gpio/gpio-timberdale.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Andy Shevchenko Aug. 1, 2023, 7:10 p.m. UTC | #1 
On Tue, Aug 01, 2023 at 10:32:11AM +0300, Andrei Coardos wrote:
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.

Reviewed-by: Andy Shevchenko <andy@kernel.org>
diff mbox series

Patch

diff --git a/drivers/gpio/gpio-timberdale.c b/drivers/gpio/gpio-timberdale.c
index de14949a3fe5..bbd9e9191199 100644
--- a/drivers/gpio/gpio-timberdale.c
+++ b/drivers/gpio/gpio-timberdale.c
@@ -256,8 +256,6 @@  static int timbgpio_probe(struct platform_device *pdev)
 	if (err)
 		return err;
 
-	platform_set_drvdata(pdev, tgpio);
-
 	/* make sure to disable interrupts */
 	iowrite32(0x0, tgpio->membase + TGPIO_IER);