diff mbox series

gpio: sch: remove unneeded call to platform_set_drvdata()

Message ID 20230801072800.4130-1-aboutphysycs@gmail.com
State Accepted
Commit b11eba8b02e592b69b41af01ab7325a853441908
Headers show
Series gpio: sch: remove unneeded call to platform_set_drvdata() | expand

Commit Message

Andrei Coardos Aug. 1, 2023, 7:28 a.m. UTC 
This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata() call to access the private data of the driver. Also,
the private data is defined in this driver, so there is no risk of it being
accessed outside of this driver file.

Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
---
 drivers/gpio/gpio-sch.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Andy Shevchenko Aug. 1, 2023, 7:03 p.m. UTC | #1 
On Tue, Aug 01, 2023 at 10:28:00AM +0300, Andrei Coardos wrote:
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.

Reviewed-by: Andy Shevchenko <andy@kernel.org>
diff mbox series

Patch

diff --git a/drivers/gpio/gpio-sch.c b/drivers/gpio/gpio-sch.c
index 8a83f7bf4382..e48392074e4b 100644
--- a/drivers/gpio/gpio-sch.c
+++ b/drivers/gpio/gpio-sch.c
@@ -380,8 +380,6 @@  static int sch_gpio_probe(struct platform_device *pdev)
 		return -ENODEV;
 	}
 
-	platform_set_drvdata(pdev, sch);
-
 	girq = &sch->chip.irq;
 	gpio_irq_chip_set_chip(girq, &sch_irqchip);
 	girq->num_parents = 0;