| Message ID | 20230801133458.6837-1-peter.wang@mediatek.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v1] ufs: core: only suspend clock scaling if scale down | expand |
Hi all, Gentle ping for this bug fix review. Thanks. On Tue, 2023-08-01 at 21:34 +0800, peter.wang@mediatek.com wrote: > From: Peter Wang <peter.wang@mediatek.com> > > If clock scale up and suspend clock scaling, ufs will keep high > performance/power mode but no read/write requests on going. > It is logic wrong and have power concern. > > Fixes: 401f1e4490ee ("scsi: ufs: don't suspend clock scaling during > clock gating") > Cc: <stable@vger.kernel.org> > Signed-off-by: Peter Wang <peter.wang@mediatek.com> > --- > drivers/ufs/core/ufshcd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c > index 129446775796..e3672e55efae 100644 > --- a/drivers/ufs/core/ufshcd.c > +++ b/drivers/ufs/core/ufshcd.c > @@ -1458,7 +1458,7 @@ static int ufshcd_devfreq_target(struct device > *dev, > ktime_to_us(ktime_sub(ktime_get(), start)), ret); > > out: > - if (sched_clk_scaling_suspend_work) > + if (sched_clk_scaling_suspend_work && !scale_up) > queue_work(hba->clk_scaling.workq, > &hba->clk_scaling.suspend_work); >
On 8/1/23 06:34, peter.wang@mediatek.com wrote: > From: Peter Wang <peter.wang@mediatek.com> > > If clock scale up and suspend clock scaling, ufs will keep high > performance/power mode but no read/write requests on going. > It is logic wrong and have power concern. > > Fixes: 401f1e4490ee ("scsi: ufs: don't suspend clock scaling during clock gating") > Cc: <stable@vger.kernel.org> > Signed-off-by: Peter Wang <peter.wang@mediatek.com> > --- > drivers/ufs/core/ufshcd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c > index 129446775796..e3672e55efae 100644 > --- a/drivers/ufs/core/ufshcd.c > +++ b/drivers/ufs/core/ufshcd.c > @@ -1458,7 +1458,7 @@ static int ufshcd_devfreq_target(struct device *dev, > ktime_to_us(ktime_sub(ktime_get(), start)), ret); > > out: > - if (sched_clk_scaling_suspend_work) > + if (sched_clk_scaling_suspend_work && !scale_up) > queue_work(hba->clk_scaling.workq, > &hba->clk_scaling.suspend_work); Reviewed-by: Bart Van Assche <bvanassche@acm.org>
diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c index 129446775796..e3672e55efae 100644 --- a/drivers/ufs/core/ufshcd.c +++ b/drivers/ufs/core/ufshcd.c @@ -1458,7 +1458,7 @@ static int ufshcd_devfreq_target(struct device *dev, ktime_to_us(ktime_sub(ktime_get(), start)), ret); out: - if (sched_clk_scaling_suspend_work) + if (sched_clk_scaling_suspend_work && !scale_up) queue_work(hba->clk_scaling.workq, &hba->clk_scaling.suspend_work);