[PATCHv5,10/13] net/lwip: update .gitignore with lwip

Message ID	20230802140658.10319-11-maxim.uvarov@linaro.org
State	New
Headers	show Delivered-To: patch@linaro.org Received-SPF: pass (google.com: domain of u-boot-bounces@lists.denx.de designates 85.214.62.61 as permitted sender) client-ip=85.214.62.61; From: Maxim Uvarov <maxim.uvarov@linaro.org> To: u-boot@lists.denx.de Cc: pbrobinson@redhat.com, ilias.apalodimas@linaro.org, joe.hershberger@ni.com, rfried.dev@gmail.com, trini@konsulko.com, goldsimon@gmx.de, lwip-devel@nongnu.org, Maxim Uvarov <maxim.uvarov@linaro.org> Subject: [PATCHv5 10/13] net/lwip: update .gitignore with lwip Date: Wed, 2 Aug 2023 20:06:55 +0600 Message-Id: <20230802140658.10319-11-maxim.uvarov@linaro.org> In-Reply-To: <20230802140658.10319-1-maxim.uvarov@linaro.org> References: <20230802140658.10319-1-maxim.uvarov@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" <u-boot-bounces@lists.denx.de>
Series	net/lwip: add lwip library for the network stack \| expand [PATCHv5,00/13] net/lwip: add lwip library for the network stack [PATCHv5,01/13] net/lwip: add doc/develop/net_lwip.rst [PATCHv5,02/13] net/lwip: integrate lwip library [PATCHv5,03/13] net/lwip: implement dns cmd [PATCHv5,04/13] net/lwip: implement dhcp cmd [PATCHv5,05/13] net/lwip: implement tftp cmd [PATCHv5,06/13] net/lwip: implement wget cmd [PATCHv5,07/13] net/lwip: implement ping cmd [PATCHv5,08/13] net/lwip: add lwip configuration configuration [PATCHv5,09/13] net/lwip: implement lwip port to u-boot [PATCHv5,10/13] net/lwip: update .gitignore with lwip [PATCHv5,11/13] net/lwip: connection between cmd and lwip apps [PATCHv5,12/13] net/lwip: replace original net commands with lwip [PATCHv5,13/13] net/lwip: drop old net/wget

Message ID

20230802140658.10319-11-maxim.uvarov@linaro.org

State

New

Headers

Received-SPF: pass (google.com: domain of u-boot-bounces@lists.denx.de
 designates 85.214.62.61 as permitted sender) client-ip=85.214.62.61;
From: Maxim Uvarov <maxim.uvarov@linaro.org>
To: u-boot@lists.denx.de
Cc: pbrobinson@redhat.com, ilias.apalodimas@linaro.org,
 joe.hershberger@ni.com,
 rfried.dev@gmail.com, trini@konsulko.com, goldsimon@gmx.de,
 lwip-devel@nongnu.org, Maxim Uvarov <maxim.uvarov@linaro.org>
Subject: [PATCHv5 10/13] net/lwip: update .gitignore with lwip
Date: Wed,  2 Aug 2023 20:06:55 +0600
Message-Id: <20230802140658.10319-11-maxim.uvarov@linaro.org>
In-Reply-To: <20230802140658.10319-1-maxim.uvarov@linaro.org>
References: <20230802140658.10319-1-maxim.uvarov@linaro.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: list
Errors-To: u-boot-bounces@lists.denx.de
Sender: "U-Boot" <u-boot-bounces@lists.denx.de>

Series

net/lwip: add lwip library for the network stack | expand

Comments

Simon Glass Aug. 2, 2023, 9:31 p.m. UTC | #1

Hi Maxim,

On Wed, 2 Aug 2023 at 08:11, Maxim Uvarov <maxim.uvarov@linaro.org> wrote:
>
> Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>
> ---
>  .gitignore | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/.gitignore b/.gitignore
> index 3a4d056edf..9f2935f917 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -108,3 +108,12 @@ __pycache__
>
>  # moveconfig database
>  /moveconfig.db
> +
> +lib/lwip/lwip-external
> +lib/lwip/apps/ping/ping.c
> +lib/lwip/apps/http/http_client.c
> +lib/lwip/apps/http/http_client.h
> +lib/lwip/apps/tftp/tftp.c
> +lib/lwip/apps/tftp/tftp_client.h
> +lib/lwip/apps/tftp/tftp_common.h
> +lib/lwip/apps/tftp/tftp_example.h

Would it be OK to put these in lib/lwip/.gitignore ?

> --
> 2.30.2
>

Regards,
Simon

Ilias Apalodimas Aug. 3, 2023, 6:01 a.m. UTC | #2

Hi Maxim

On Wed, 2 Aug 2023 at 17:09, Maxim Uvarov <maxim.uvarov@linaro.org> wrote:
>
> Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>

You need to try and be a bit more formal.  This is past the RFC stage,
you need commit messages that make sense.

Thanks
/Ilias
> ---
>  .gitignore | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/.gitignore b/.gitignore
> index 3a4d056edf..9f2935f917 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -108,3 +108,12 @@ __pycache__
>
>  # moveconfig database
>  /moveconfig.db
> +
> +lib/lwip/lwip-external
> +lib/lwip/apps/ping/ping.c
> +lib/lwip/apps/http/http_client.c
> +lib/lwip/apps/http/http_client.h
> +lib/lwip/apps/tftp/tftp.c
> +lib/lwip/apps/tftp/tftp_client.h
> +lib/lwip/apps/tftp/tftp_common.h
> +lib/lwip/apps/tftp/tftp_example.h
> --
> 2.30.2
>

diff --git a/.gitignore b/.gitignore
index 3a4d056edf..9f2935f917 100644
--- a/.gitignore
+++ b/.gitignore
@@ -108,3 +108,12 @@  __pycache__
 
 # moveconfig database
 /moveconfig.db
+
+lib/lwip/lwip-external
+lib/lwip/apps/ping/ping.c
+lib/lwip/apps/http/http_client.c
+lib/lwip/apps/http/http_client.h
+lib/lwip/apps/tftp/tftp.c
+lib/lwip/apps/tftp/tftp_client.h
+lib/lwip/apps/tftp/tftp_common.h
+lib/lwip/apps/tftp/tftp_example.h

[PATCHv5,10/13] net/lwip: update .gitignore with lwip

Commit Message

Comments

Patch