diff mbox series

[-next] spi: mpc5xxx-psc: Fix unsigned expression compared with zero

Message ID 20230803134805.1037251-1-lizetao1@huawei.com
State Accepted
Commit de5e92cb5cefd2968b96075995a36e28298edf71
Headers show
Series [-next] spi: mpc5xxx-psc: Fix unsigned expression compared with zero | expand

Commit Message

Li Zetao Aug. 3, 2023, 1:48 p.m. UTC
There is two warnings reported by coccinelle:

./drivers/spi/spi-mpc512x-psc.c:493:5-13: WARNING:
	Unsigned expression compared with zero: mps -> irq     <     0
./drivers/spi/spi-mpc52xx-psc.c:332:5-13: WARNING:
	Unsigned expression compared with zero: mps -> irq     <     0

The commit "208ee586f862"
("spi: mpc5xxx-psc: Return immediately if IRQ resource is unavailable")
was to check whether the IRQ resource is unavailable. When the IRQ
resource is unavailable, an error code is returned, however, the type
of "mps->irq" is "unsigned int", causing the error code to flip. Modify
the type of "mps->irq" to solve this problem.

Fixes: 208ee586f862 ("spi: mpc5xxx-psc: Return immediately if IRQ resource is unavailable")
Signed-off-by: Li Zetao <lizetao1@huawei.com>
---
 drivers/spi/spi-mpc512x-psc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mark Brown Aug. 3, 2023, 6:26 p.m. UTC | #1
On Thu, 03 Aug 2023 21:48:05 +0800, Li Zetao wrote:
> There is two warnings reported by coccinelle:
> 
> ./drivers/spi/spi-mpc512x-psc.c:493:5-13: WARNING:
> 	Unsigned expression compared with zero: mps -> irq     <     0
> ./drivers/spi/spi-mpc52xx-psc.c:332:5-13: WARNING:
> 	Unsigned expression compared with zero: mps -> irq     <     0
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: mpc5xxx-psc: Fix unsigned expression compared with zero
      commit: de5e92cb5cefd2968b96075995a36e28298edf71

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/drivers/spi/spi-mpc512x-psc.c b/drivers/spi/spi-mpc512x-psc.c
index 99aeef28a477..5cecca1bef02 100644
--- a/drivers/spi/spi-mpc512x-psc.c
+++ b/drivers/spi/spi-mpc512x-psc.c
@@ -53,7 +53,7 @@  struct mpc512x_psc_spi {
 	int type;
 	void __iomem *psc;
 	struct mpc512x_psc_fifo __iomem *fifo;
-	unsigned int irq;
+	int irq;
 	u8 bits_per_word;
 	u32 mclk_rate;