| Message ID | 20230804102703.931418-3-like@awinic.com |
|---|---|
| State | New |
| Headers | show |
| Series | regulator: aw37503: add regulator driver for AWINIC AW37503 | expand |
On 04/08/2023 12:27, like@awinic.com wrote: > From: Alec Li <like@awinic.com> > ... Subject: no improvements > + > +properties: > + compatible: > + const: awinic,aw37503 > + > + reg: > + maxItems: 1 > + > +patternProperties: > + "^out[pn]$": > + type: object > + $ref: regulator.yaml# This does not make much sense. You had here unvaluatedProperties. Why dropping it? I asked to drop additionalProperties. Open the email and look where the comments are given. In which context. > + > +additionalProperties: false > + > +required: > + - compatible > + - reg > + - outp > + - outn > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + regulator@3e { > + compatible = "awinic,aw37503"; > + reg = <0x3e>; > + > + outp { > + regulator-name = "outp"; > + regulator-boot-on; > + regulator-always-on; > + enable-gpios = <&gpio 17 0>; Please use proper defines.... you included the header for this. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/regulator/awinic,aw37503.yaml b/Documentation/devicetree/bindings/regulator/awinic,aw37503.yaml index 000000000000..bb551f6cbccd --- /dev/null +++ b/Documentation/devicetree/bindings/regulator/awinic,aw37503.yaml @@ -0,0 +1,65 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/regulator/awinic,aw37503.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Awinic AW37503 Voltage Regulator + +maintainers: + - Alec Li <like@awinic.com> + +description: + The AW37503 are dual voltage regulator, designed to support positive/negative + supply for driving TFT-LCD panels. It support software-configurable output + switching and monitoring. The output voltages can be programmed via an I2C + compatible interface. + +properties: + compatible: + const: awinic,aw37503 + + reg: + maxItems: 1 + +patternProperties: + "^out[pn]$": + type: object + $ref: regulator.yaml# + +additionalProperties: false + +required: + - compatible + - reg + - outp + - outn + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + + i2c { + #address-cells = <1>; + #size-cells = <0>; + + regulator@3e { + compatible = "awinic,aw37503"; + reg = <0x3e>; + + outp { + regulator-name = "outp"; + regulator-boot-on; + regulator-always-on; + enable-gpios = <&gpio 17 0>; + }; + + outn { + regulator-name = "outn"; + regulator-boot-on; + regulator-always-on; + enable-gpios = <&gpio 27 0>; + }; + }; + }; +...