diff mbox series

[1/1] lpfc: Modify when a node should be put in device recovery mode during RSCN

Message ID 20230804195546.157839-1-justintee8345@gmail.com
State New
Headers show
Series [1/1] lpfc: Modify when a node should be put in device recovery mode during RSCN | expand

Commit Message

Justin Tee Aug. 4, 2023, 7:55 p.m. UTC
Only nodes whose state is at least past a PLOGI issue and strictly less
than a PRLI issue should be put into device recovery mode upon RSCN
receipt.  Previously, the allowance of LOGO and PRLI completion states did
not make sense because those nodes should be allowed to flow through and
marked as NPort dissappeared as is normally done.  A follow up RSCN
GID_FT would recover those nodes in such cases.

Signed-off-by: Justin Tee <justin.tee@broadcom.com>
---
 drivers/scsi/lpfc/lpfc_hbadisc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Martin K. Petersen Aug. 8, 2023, 1:26 a.m. UTC | #1
Justin,

> Only nodes whose state is at least past a PLOGI issue and strictly
> less than a PRLI issue should be put into device recovery mode upon
> RSCN receipt. Previously, the allowance of LOGO and PRLI completion
> states did not make sense because those nodes should be allowed to
> flow through and marked as NPort dissappeared as is normally done. A
> follow up RSCN GID_FT would recover those nodes in such cases.

Applied to 6.6/scsi-staging, thanks!
diff mbox series

Patch

diff --git a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c
index 388a481c8118..467c255bbe4c 100644
--- a/drivers/scsi/lpfc/lpfc_hbadisc.c
+++ b/drivers/scsi/lpfc/lpfc_hbadisc.c
@@ -5782,7 +5782,7 @@  lpfc_setup_disc_node(struct lpfc_vport *vport, uint32_t did)
 				return NULL;
 
 			if (ndlp->nlp_state > NLP_STE_UNUSED_NODE &&
-			    ndlp->nlp_state < NLP_STE_NPR_NODE) {
+			    ndlp->nlp_state < NLP_STE_PRLI_ISSUE) {
 				lpfc_disc_state_machine(vport, ndlp, NULL,
 							NLP_EVT_DEVICE_RECOVERY);
 			}