| Message ID | 1467120338-12587-2-git-send-email-lersek@redhat.com |
|---|---|
| State | Accepted |
| Commit | 0206697943b70400a6cd159b38b7723f8896e59d |
| Headers | show |
Hi Giri,
On 06/30/16 06:40, Mudusuru, Giri P wrote:
> Reviewed-by: Giri P Mudusuru <giri.p.mudusuru@intel.com>
Thank you for the reviews -- I did find and pick up your R-b messages
soon after you sent them.
There's no need to send repeated R-b's to the same patches. For example,
this patch has two R-b's from you at the moment:
http://thread.gmane.org/gmane.comp.bios.edk2.devel/13736/focus=13764
http://thread.gmane.org/gmane.comp.bios.edk2.devel/13736/focus=13884
I've been waiting for a maintainer R-b for patch #4 -- that's the one
piece missing for me to commit the series.
Thank you
Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
diff --git a/EdkCompatibilityPkg/Compatibility/FrameworkHiiOnUefiHiiThunk/HiiDatabase.c b/EdkCompatibilityPkg/Compatibility/FrameworkHiiOnUefiHiiThunk/HiiDatabase.c index 386ff327f81b..2d456da30353 100644 --- a/EdkCompatibilityPkg/Compatibility/FrameworkHiiOnUefiHiiThunk/HiiDatabase.c +++ b/EdkCompatibilityPkg/Compatibility/FrameworkHiiOnUefiHiiThunk/HiiDatabase.c @@ -494,7 +494,7 @@ HiiGetSecondaryLanguages ( UnicodeStrToAsciiStr (PrimaryLanguage, PrimaryLang639); PrimaryLang4646 = ConvertLanguagesIso639ToRfc4646 (PrimaryLang639); - ASSERT_EFI_ERROR (PrimaryLang4646 != NULL); + ASSERT (PrimaryLang4646 != NULL); SecLangCodes4646 = HiiGetSupportedSecondaryLanguages (UefiHiiHandle, PrimaryLang4646); diff --git a/EdkCompatibilityPkg/Compatibility/FrameworkHiiOnUefiHiiThunk/Utility.c b/EdkCompatibilityPkg/Compatibility/FrameworkHiiOnUefiHiiThunk/Utility.c index f6d97f63444f..d269b8e4d6ba 100644 --- a/EdkCompatibilityPkg/Compatibility/FrameworkHiiOnUefiHiiThunk/Utility.c +++ b/EdkCompatibilityPkg/Compatibility/FrameworkHiiOnUefiHiiThunk/Utility.c @@ -153,7 +153,7 @@ ExportPackageLists ( &Size, PackageListHdr ); - ASSERT_EFI_ERROR (Status != EFI_BUFFER_TOO_SMALL); + ASSERT (Status != EFI_BUFFER_TOO_SMALL); if (Status == EFI_BUFFER_TOO_SMALL) { PackageListHdr = AllocateZeroPool (Size);
A number of code locations use ASSERT_EFI_ERROR (BooleanExpression) instead of ASSERT (BooleanExpression) Fix them. Cc: Liming Gao <liming.gao@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek <lersek@redhat.com> --- Notes: build tested only EdkCompatibilityPkg/Compatibility/FrameworkHiiOnUefiHiiThunk/HiiDatabase.c | 2 +- EdkCompatibilityPkg/Compatibility/FrameworkHiiOnUefiHiiThunk/Utility.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- 1.8.3.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel