| Message ID | 20230804090120.1332091-1-yangyingliang@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | [-next] wifi: rtlwifi: use eth_broadcast_addr() to assign broadcast address | expand |
> -----Original Message----- > From: Yang Yingliang <yangyingliang@huawei.com> > Sent: Friday, August 4, 2023 5:01 PM > To: linux-wireless@vger.kernel.org > Cc: Ping-Ke Shih <pkshih@realtek.com>; kvalo@kernel.org; yangyingliang@huawei.com > Subject: [PATCH -next] wifi: rtlwifi: use eth_broadcast_addr() to assign broadcast address > > Use eth_broadcast_addr() to assign broadcast address instead > of memcpy(). > > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Acked-by: Ping-Ke Shih <pkshih@realtek.com> > --- > drivers/net/wireless/realtek/rtlwifi/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/realtek/rtlwifi/core.c b/drivers/net/wireless/realtek/rtlwifi/core.c > index 4fb16f5f6f83..3835b639d453 100644 > --- a/drivers/net/wireless/realtek/rtlwifi/core.c > +++ b/drivers/net/wireless/realtek/rtlwifi/core.c > @@ -1656,7 +1656,7 @@ static int rtl_op_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd, > memcpy(rtlpriv->sec.key_buf[key_idx], > key->key, key->keylen); > rtlpriv->sec.key_len[key_idx] = key->keylen; > - memcpy(mac_addr, bcast_addr, ETH_ALEN); > + eth_broadcast_addr(mac_addr); > } else { /* pairwise key */ > rtl_dbg(rtlpriv, COMP_SEC, DBG_DMESG, > "set pairwise key\n"); > -- > 2.25.1 > > > ------Please consider the environment before printing this e-mail.
Yang Yingliang <yangyingliang@huawei.com> wrote: > Use eth_broadcast_addr() to assign broadcast address instead > of memcpy(). > > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > Acked-by: Ping-Ke Shih <pkshih@realtek.com> Patch applied to wireless-next.git, thanks. 66311106b20b wifi: rtlwifi: use eth_broadcast_addr() to assign broadcast address
diff --git a/drivers/net/wireless/realtek/rtlwifi/core.c b/drivers/net/wireless/realtek/rtlwifi/core.c index 4fb16f5f6f83..3835b639d453 100644 --- a/drivers/net/wireless/realtek/rtlwifi/core.c +++ b/drivers/net/wireless/realtek/rtlwifi/core.c @@ -1656,7 +1656,7 @@ static int rtl_op_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd, memcpy(rtlpriv->sec.key_buf[key_idx], key->key, key->keylen); rtlpriv->sec.key_len[key_idx] = key->keylen; - memcpy(mac_addr, bcast_addr, ETH_ALEN); + eth_broadcast_addr(mac_addr); } else { /* pairwise key */ rtl_dbg(rtlpriv, COMP_SEC, DBG_DMESG, "set pairwise key\n");
Use eth_broadcast_addr() to assign broadcast address instead of memcpy(). Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/net/wireless/realtek/rtlwifi/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)