| Message ID | 1467201583-4892-1-git-send-email-bill.fischofer@linaro.org |
|---|---|
| State | Accepted |
| Commit | 50078445f1a944309fb88946582a2015fd098f6b |
| Headers | show |
Merged, Maxim. On 06/29/16 15:36, Savolainen, Petri (Nokia - FI/Espoo) wrote: > This patch: > Reviewed-by: Petri Savolainen <petri.savolainen@nokia.com> > > >> -----Original Message----- >> From: lng-odp [mailto:lng-odp-bounces@lists.linaro.org] On Behalf Of Bill >> Fischofer >> Sent: Wednesday, June 29, 2016 3:00 PM >> To: lng-odp@lists.linaro.org >> Subject: [lng-odp] [PATCHv3 1/2] validation: queue: avoid out of bounds >> references >> >> Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2377 by correcting >> loop bounds for error case. >> >> Signed-off-by: Bill Fischofer <bill.fischofer@linaro.org> >> --- >> test/validation/queue/queue.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/test/validation/queue/queue.c b/test/validation/queue/queue.c >> index be9c0dc..96941f4 100644 >> --- a/test/validation/queue/queue.c >> +++ b/test/validation/queue/queue.c >> @@ -84,7 +84,7 @@ void queue_test_capa(void) >> >> if (queue[i] == ODP_QUEUE_INVALID) { >> CU_FAIL("Queue create failed"); >> - num_queues = i - 1; >> + num_queues = i; >> break; >> } >> >> -- >> 2.7.4 >> >> _______________________________________________ >> lng-odp mailing list >> lng-odp@lists.linaro.org >> https://lists.linaro.org/mailman/listinfo/lng-odp > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp
On 06/30/16 09:49, Savolainen, Petri (Nokia - FI/Espoo) wrote: > Maxim, could you revert patch 2/2 (validation: queue: use malloc to avoid limits on max_queues). Only 1/2 was agreed to be merged. Max_queue test will be added as separate test case. > > -Petri Ok, reverted. Maxim. > >> -----Original Message----- >> From: lng-odp [mailto:lng-odp-bounces@lists.linaro.org] On Behalf Of Maxim >> Uvarov >> Sent: Wednesday, June 29, 2016 7:27 PM >> To: lng-odp@lists.linaro.org >> Subject: Re: [lng-odp] [PATCHv3 1/2] validation: queue: avoid out of >> bounds references >> >> Merged, >> Maxim. >> >> On 06/29/16 15:36, Savolainen, Petri (Nokia - FI/Espoo) wrote: >>> This patch: >>> Reviewed-by: Petri Savolainen <petri.savolainen@nokia.com> >>> >>> >>>> -----Original Message----- >>>> From: lng-odp [mailto:lng-odp-bounces@lists.linaro.org] On Behalf Of >> Bill >>>> Fischofer >>>> Sent: Wednesday, June 29, 2016 3:00 PM >>>> To: lng-odp@lists.linaro.org >>>> Subject: [lng-odp] [PATCHv3 1/2] validation: queue: avoid out of bounds >>>> references >>>> >>>> Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2377 by correcting >>>> loop bounds for error case. >>>> >>>> Signed-off-by: Bill Fischofer <bill.fischofer@linaro.org> >>>> --- >>>> test/validation/queue/queue.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/test/validation/queue/queue.c >> b/test/validation/queue/queue.c >>>> index be9c0dc..96941f4 100644 >>>> --- a/test/validation/queue/queue.c >>>> +++ b/test/validation/queue/queue.c >>>> @@ -84,7 +84,7 @@ void queue_test_capa(void) >>>> >>>> if (queue[i] == ODP_QUEUE_INVALID) { >>>> CU_FAIL("Queue create failed"); >>>> - num_queues = i - 1; >>>> + num_queues = i; >>>> break; >>>> } >>>> >>>> -- >>>> 2.7.4 >>>> >>>> _______________________________________________ >>>> lng-odp mailing list >>>> lng-odp@lists.linaro.org >>>> https://lists.linaro.org/mailman/listinfo/lng-odp >>> _______________________________________________ >>> lng-odp mailing list >>> lng-odp@lists.linaro.org >>> https://lists.linaro.org/mailman/listinfo/lng-odp >> _______________________________________________ >> lng-odp mailing list >> lng-odp@lists.linaro.org >> https://lists.linaro.org/mailman/listinfo/lng-odp
diff --git a/test/validation/queue/queue.c b/test/validation/queue/queue.c index be9c0dc..96941f4 100644 --- a/test/validation/queue/queue.c +++ b/test/validation/queue/queue.c @@ -84,7 +84,7 @@ void queue_test_capa(void) if (queue[i] == ODP_QUEUE_INVALID) { CU_FAIL("Queue create failed"); - num_queues = i - 1; + num_queues = i; break; }
Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2377 by correcting loop bounds for error case. Signed-off-by: Bill Fischofer <bill.fischofer@linaro.org> --- test/validation/queue/queue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)