diff mbox series

[2/3] crypto: qcom-rng: Make the core clock optional regardless of ACPI presence

Message ID 20230811-topic-8450_prng-v1-2-01becceeb1ee@linaro.org
State Accepted
Commit cdb8b7e1692a81f26030050ec30aadd2e7538fef
Headers show
Series Introduce PRNG on SM8450 | expand

Commit Message

Konrad Dybcio Aug. 11, 2023, 8:50 p.m. UTC
Some newer SoCs (like SM8450) do not require a clock vote for the PRNG
to function. Make it entirely optional and rely on the bindings checker
to ensure platforms that need it, consume one.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 drivers/crypto/qcom-rng.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

Comments

Bjorn Andersson Aug. 14, 2023, 2:39 a.m. UTC | #1
On Fri, Aug 11, 2023 at 10:50:57PM +0200, Konrad Dybcio wrote:
> Some newer SoCs (like SM8450) do not require a clock vote for the PRNG
> to function. Make it entirely optional and rely on the bindings checker
> to ensure platforms that need it, consume one.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Reviewed-by: Bjorn Andersson <andersson@kernel.org>

Regards,
Bjorn
diff mbox series

Patch

diff --git a/drivers/crypto/qcom-rng.c b/drivers/crypto/qcom-rng.c
index 72dd1a4ebac4..825a729f205e 100644
--- a/drivers/crypto/qcom-rng.c
+++ b/drivers/crypto/qcom-rng.c
@@ -173,13 +173,9 @@  static int qcom_rng_probe(struct platform_device *pdev)
 	if (IS_ERR(rng->base))
 		return PTR_ERR(rng->base);
 
-	/* ACPI systems have clk already on, so skip clk_get */
-	if (!has_acpi_companion(&pdev->dev)) {
-		rng->clk = devm_clk_get(&pdev->dev, "core");
-		if (IS_ERR(rng->clk))
-			return PTR_ERR(rng->clk);
-	}
-
+	rng->clk = devm_clk_get_optional(&pdev->dev, "core");
+	if (IS_ERR(rng->clk))
+		return PTR_ERR(rng->clk);
 
 	rng->skip_init = (unsigned long)device_get_match_data(&pdev->dev);