diff mbox series

[v1] watchdog: intel-mid_wdt: add MODULE_ALIAS() to allow auto-load

Message ID 20230811120220.31578-1-raag.jadav@intel.com
State New
Headers show
Series [v1] watchdog: intel-mid_wdt: add MODULE_ALIAS() to allow auto-load | expand

Commit Message

Raag Jadav Aug. 11, 2023, 12:02 p.m. UTC
When built with CONFIG_INTEL_MID_WATCHDOG=m, currently the driver
needs to be loaded manually, for the lack of module alias.
This causes unintended resets in cases where watchdog timer is
set-up by bootloader and the driver is not explicitly loaded.
Add MODULE_ALIAS() to load the driver automatically at boot and
avoid this issue.

Fixes: 87a1ef8058d9 ("watchdog: add Intel MID watchdog driver support")
Signed-off-by: Raag Jadav <raag.jadav@intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/watchdog/intel-mid_wdt.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Guenter Roeck Aug. 11, 2023, 12:20 p.m. UTC | #1
On 8/11/23 05:02, Raag Jadav wrote:
> When built with CONFIG_INTEL_MID_WATCHDOG=m, currently the driver
> needs to be loaded manually, for the lack of module alias.
> This causes unintended resets in cases where watchdog timer is
> set-up by bootloader and the driver is not explicitly loaded.
> Add MODULE_ALIAS() to load the driver automatically at boot and
> avoid this issue.
> 
> Fixes: 87a1ef8058d9 ("watchdog: add Intel MID watchdog driver support")
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   drivers/watchdog/intel-mid_wdt.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/watchdog/intel-mid_wdt.c b/drivers/watchdog/intel-mid_wdt.c
> index 9b2173f765c8..fb7fae750181 100644
> --- a/drivers/watchdog/intel-mid_wdt.c
> +++ b/drivers/watchdog/intel-mid_wdt.c
> @@ -203,3 +203,4 @@ module_platform_driver(mid_wdt_driver);
>   MODULE_AUTHOR("David Cohen <david.a.cohen@linux.intel.com>");
>   MODULE_DESCRIPTION("Watchdog Driver for Intel MID platform");
>   MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform:intel_mid_wdt");
diff mbox series

Patch

diff --git a/drivers/watchdog/intel-mid_wdt.c b/drivers/watchdog/intel-mid_wdt.c
index 9b2173f765c8..fb7fae750181 100644
--- a/drivers/watchdog/intel-mid_wdt.c
+++ b/drivers/watchdog/intel-mid_wdt.c
@@ -203,3 +203,4 @@  module_platform_driver(mid_wdt_driver);
 MODULE_AUTHOR("David Cohen <david.a.cohen@linux.intel.com>");
 MODULE_DESCRIPTION("Watchdog Driver for Intel MID platform");
 MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:intel_mid_wdt");