| Message ID | 20230813141207.150336-1-coolrrsh@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2] spi: spi-mpc512x-psc: Fix an unsigned comparison that can never be negative | expand |
On Wed, Aug 16, 2023 at 11:38:48AM +0530, Rajeshwar Shinde wrote: > Please verify this patch. > Thanks & Regards Please don't send content free pings and please allow a reasonable time for review. People get busy, go on holiday, attend conferences and so on so unless there is some reason for urgency (like critical bug fixes) please allow at least a couple of weeks for review. If there have been review comments then people may be waiting for those to be addressed. Sending content free pings adds to the mail volume (if they are seen at all) which is often the problem and since they can't be reviewed directly if something has gone wrong you'll have to resend the patches anyway, so sending again is generally a better approach though there are some other maintainers who like them - if in doubt look at how patches for the subsystem are normally handled. Please don't top post, reply in line with needed context. This allows readers to readily follow the flow of conversation and understand what you are talking about and also helps ensure that everything in the discussion is being addressed.
On Sun, Sep 03, 2023 at 08:12:25PM +0530, Rajeshwar Shinde wrote: > Remainder Please read the mail you are replying to... > On Wed, 16 Aug, 2023, 5:02 pm Mark Brown, <broonie@kernel.org> wrote: > > > On Wed, Aug 16, 2023 at 11:38:48AM +0530, Rajeshwar Shinde wrote: > > > Please verify this patch. > > > Thanks & Regards > > > > Please don't send content free pings and please allow a reasonable time > > for review. People get busy, go on holiday, attend conferences and so > > on so unless there is some reason for urgency (like critical bug fixes) > > please allow at least a couple of weeks for review. If there have been > > review comments then people may be waiting for those to be addressed. > > > > Sending content free pings adds to the mail volume (if they are seen at > > all) which is often the problem and since they can't be reviewed > > directly if something has gone wrong you'll have to resend the patches > > anyway, so sending again is generally a better approach though there are > > some other maintainers who like them - if in doubt look at how patches > > for the subsystem are normally handled. > > > > Please don't top post, reply in line with needed context. This allows > > readers to readily follow the flow of conversation and understand what > > you are talking about and also helps ensure that everything in the > > discussion is being addressed. > >
On Sat, Dec 02, 2023 at 10:00:21AM +0530, Rajeshwar Shinde wrote:
> Remainder
Seriously, please read and act on what I'm writing.
diff --git a/drivers/spi/spi-mpc512x-psc.c b/drivers/spi/spi-mpc512x-psc.c index 99aeef28a..5cecca1be 100644 --- a/drivers/spi/spi-mpc512x-psc.c +++ b/drivers/spi/spi-mpc512x-psc.c @@ -53,7 +53,7 @@ struct mpc512x_psc_spi { int type; void __iomem *psc; struct mpc512x_psc_fifo __iomem *fifo; - unsigned int irq; + int irq; u8 bits_per_word; u32 mclk_rate;