diff mbox series

[v1,1/2] media: i2c: imx219: Fix a typo referring to a wrong variable

Message ID 20230814193435.24158-2-laurent.pinchart@ideasonboard.com
State Accepted
Commit 5cb218ffc54f1865edbe0c2a5ac4e906753817fb
Headers show
Series media: i2c: imx219: Miscellaneous fixes | expand

Commit Message

Laurent Pinchart Aug. 14, 2023, 7:34 p.m. UTC
The imx219_init_cfg() function has stopped operating on the try format
since commit 7e700847b1fe ("media: i2c: imx219: Switch from open to
init_cfg"), but a comment in the function wasn't updated. Fix it.

While at it, improve spelling in a second comment in the function.

Fixes: 7e700847b1fe ("media: i2c: imx219: Switch from open to init_cfg")
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 drivers/media/i2c/imx219.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Jacopo Mondi Aug. 28, 2023, 12:18 p.m. UTC | #1
Hi Laurent

On Mon, Aug 14, 2023 at 10:34:34PM +0300, Laurent Pinchart wrote:
> The imx219_init_cfg() function has stopped operating on the try format
> since commit 7e700847b1fe ("media: i2c: imx219: Switch from open to
> init_cfg"), but a comment in the function wasn't updated. Fix it.
>
> While at it, improve spelling in a second comment in the function.
>
> Fixes: 7e700847b1fe ("media: i2c: imx219: Switch from open to init_cfg")
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>


> ---
>  drivers/media/i2c/imx219.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c
> index a1136fdfbed2..6f88e002c8d8 100644
> --- a/drivers/media/i2c/imx219.c
> +++ b/drivers/media/i2c/imx219.c
> @@ -691,12 +691,12 @@ static int imx219_init_cfg(struct v4l2_subdev *sd,
>  	struct v4l2_mbus_framefmt *format;
>  	struct v4l2_rect *crop;
>
> -	/* Initialize try_fmt */
> +	/* Initialize the format. */
>  	format = v4l2_subdev_get_pad_format(sd, state, 0);
>  	imx219_update_pad_format(imx219, &supported_modes[0], format,
>  				 MEDIA_BUS_FMT_SRGGB10_1X10);
>
> -	/* Initialize crop rectangle. */
> +	/* Initialize the crop rectangle. */
>  	crop = v4l2_subdev_get_pad_crop(sd, state, 0);
>  	crop->top = IMX219_PIXEL_ARRAY_TOP;
>  	crop->left = IMX219_PIXEL_ARRAY_LEFT;
> --
> Regards,
>
> Laurent Pinchart
>
diff mbox series

Patch

diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c
index a1136fdfbed2..6f88e002c8d8 100644
--- a/drivers/media/i2c/imx219.c
+++ b/drivers/media/i2c/imx219.c
@@ -691,12 +691,12 @@  static int imx219_init_cfg(struct v4l2_subdev *sd,
 	struct v4l2_mbus_framefmt *format;
 	struct v4l2_rect *crop;
 
-	/* Initialize try_fmt */
+	/* Initialize the format. */
 	format = v4l2_subdev_get_pad_format(sd, state, 0);
 	imx219_update_pad_format(imx219, &supported_modes[0], format,
 				 MEDIA_BUS_FMT_SRGGB10_1X10);
 
-	/* Initialize crop rectangle. */
+	/* Initialize the crop rectangle. */
 	crop = v4l2_subdev_get_pad_crop(sd, state, 0);
 	crop->top = IMX219_PIXEL_ARRAY_TOP;
 	crop->left = IMX219_PIXEL_ARRAY_LEFT;