| Message ID | 20230817135053.51964-1-yuehaibing@huawei.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [-next] HID: intel-ish-hid: Remove unused declarations | expand |
On Thu, 2023-08-17 at 21:50 +0800, Yue Haibing wrote: > Commit 3703f53b99e4 ("HID: intel_ish-hid: ISH Transport layer") > declared ishtp_remove_all_clients()/ishtp_can_client_connect() > but never implemented them. > > Signed-off-by: Yue Haibing <yuehaibing@huawei.com> Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> Sorry I was on vacation to ACK before. > --- > drivers/hid/intel-ish-hid/ishtp/bus.h | 1 - > drivers/hid/intel-ish-hid/ishtp/client.h | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/drivers/hid/intel-ish-hid/ishtp/bus.h > b/drivers/hid/intel-ish-hid/ishtp/bus.h > index 5bb85c932e4c..53645ac89ee8 100644 > --- a/drivers/hid/intel-ish-hid/ishtp/bus.h > +++ b/drivers/hid/intel-ish-hid/ishtp/bus.h > @@ -46,7 +46,6 @@ struct ishtp_cl_device { > }; > > int ishtp_bus_new_client(struct ishtp_device *dev); > -void ishtp_remove_all_clients(struct ishtp_device *dev); > int ishtp_cl_device_bind(struct ishtp_cl *cl); > void ishtp_cl_bus_rx_event(struct ishtp_cl_device *device); > > diff --git a/drivers/hid/intel-ish-hid/ishtp/client.h > b/drivers/hid/intel-ish-hid/ishtp/client.h > index fc62dd1495da..d9d398fadcf7 100644 > --- a/drivers/hid/intel-ish-hid/ishtp/client.h > +++ b/drivers/hid/intel-ish-hid/ishtp/client.h > @@ -109,7 +109,6 @@ struct ishtp_cl { > }; > > /* Client connection managenment internal functions */ > -int ishtp_can_client_connect(struct ishtp_device *ishtp_dev, guid_t > *uuid); > int ishtp_fw_cl_by_id(struct ishtp_device *dev, uint8_t client_id); > void ishtp_cl_send_msg(struct ishtp_device *dev, struct ishtp_cl > *cl); > void recv_ishtp_cl_msg(struct ishtp_device *dev,
diff --git a/drivers/hid/intel-ish-hid/ishtp/bus.h b/drivers/hid/intel-ish-hid/ishtp/bus.h index 5bb85c932e4c..53645ac89ee8 100644 --- a/drivers/hid/intel-ish-hid/ishtp/bus.h +++ b/drivers/hid/intel-ish-hid/ishtp/bus.h @@ -46,7 +46,6 @@ struct ishtp_cl_device { }; int ishtp_bus_new_client(struct ishtp_device *dev); -void ishtp_remove_all_clients(struct ishtp_device *dev); int ishtp_cl_device_bind(struct ishtp_cl *cl); void ishtp_cl_bus_rx_event(struct ishtp_cl_device *device); diff --git a/drivers/hid/intel-ish-hid/ishtp/client.h b/drivers/hid/intel-ish-hid/ishtp/client.h index fc62dd1495da..d9d398fadcf7 100644 --- a/drivers/hid/intel-ish-hid/ishtp/client.h +++ b/drivers/hid/intel-ish-hid/ishtp/client.h @@ -109,7 +109,6 @@ struct ishtp_cl { }; /* Client connection managenment internal functions */ -int ishtp_can_client_connect(struct ishtp_device *ishtp_dev, guid_t *uuid); int ishtp_fw_cl_by_id(struct ishtp_device *dev, uint8_t client_id); void ishtp_cl_send_msg(struct ishtp_device *dev, struct ishtp_cl *cl); void recv_ishtp_cl_msg(struct ishtp_device *dev,
Commit 3703f53b99e4 ("HID: intel_ish-hid: ISH Transport layer") declared ishtp_remove_all_clients()/ishtp_can_client_connect() but never implemented them. Signed-off-by: Yue Haibing <yuehaibing@huawei.com> --- drivers/hid/intel-ish-hid/ishtp/bus.h | 1 - drivers/hid/intel-ish-hid/ishtp/client.h | 1 - 2 files changed, 2 deletions(-)