diff mbox series

[V2,1/4] ARM: dts: sun8i: V3: add alias to cpu node

Message ID 20230819032105.67978-2-macroalpha82@gmail.com
State New
Headers show
Series [V2,1/4] ARM: dts: sun8i: V3: add alias to cpu node | expand

Commit Message

Chris Morgan Aug. 19, 2023, 3:21 a.m. UTC
From: Chris Morgan <macromorgan@hotmail.com>

Add alias to CPU node to allow board specific CPU information to be
added.

Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
---
 arch/arm/boot/dts/allwinner/sun8i-v3s.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andre Przywara Aug. 19, 2023, 10 p.m. UTC | #1
On Fri, 18 Aug 2023 22:21:02 -0500
Chris Morgan <macroalpha82@gmail.com> wrote:

Hi Chris,

> From: Chris Morgan <macromorgan@hotmail.com>
> 
> Add alias to CPU node to allow board specific CPU information to be
> added.
> 
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> ---
>  arch/arm/boot/dts/allwinner/sun8i-v3s.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/allwinner/sun8i-v3s.dtsi b/arch/arm/boot/dts/allwinner/sun8i-v3s.dtsi
> index 3b9a282c2746..2b76a5b8ec19 100644
> --- a/arch/arm/boot/dts/allwinner/sun8i-v3s.dtsi
> +++ b/arch/arm/boot/dts/allwinner/sun8i-v3s.dtsi
> @@ -71,7 +71,7 @@ cpus {
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  
> -		cpu@0 {
> +		cpu0: cpu@0 {

That's really a nitpick, but the V3s is a single core, so I think we
should just use "cpu" as the alias.

Cheers,
Andre

>  			compatible = "arm,cortex-a7";
>  			device_type = "cpu";
>  			reg = <0>;
Chris Morgan Aug. 21, 2023, 3:11 p.m. UTC | #2
On Sat, Aug 19, 2023 at 11:00:59PM +0100, Andre Przywara wrote:
> On Fri, 18 Aug 2023 22:21:02 -0500
> Chris Morgan <macroalpha82@gmail.com> wrote:
> 
> Hi Chris,
> 
> > From: Chris Morgan <macromorgan@hotmail.com>
> > 
> > Add alias to CPU node to allow board specific CPU information to be
> > added.
> > 
> > Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> > ---
> >  arch/arm/boot/dts/allwinner/sun8i-v3s.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/allwinner/sun8i-v3s.dtsi b/arch/arm/boot/dts/allwinner/sun8i-v3s.dtsi
> > index 3b9a282c2746..2b76a5b8ec19 100644
> > --- a/arch/arm/boot/dts/allwinner/sun8i-v3s.dtsi
> > +++ b/arch/arm/boot/dts/allwinner/sun8i-v3s.dtsi
> > @@ -71,7 +71,7 @@ cpus {
> >  		#address-cells = <1>;
> >  		#size-cells = <0>;
> >  
> > -		cpu@0 {
> > +		cpu0: cpu@0 {
> 
> That's really a nitpick, but the V3s is a single core, so I think we
> should just use "cpu" as the alias.

Will do. Thank you.

> 
> Cheers,
> Andre
> 
> >  			compatible = "arm,cortex-a7";
> >  			device_type = "cpu";
> >  			reg = <0>;
>
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/allwinner/sun8i-v3s.dtsi b/arch/arm/boot/dts/allwinner/sun8i-v3s.dtsi
index 3b9a282c2746..2b76a5b8ec19 100644
--- a/arch/arm/boot/dts/allwinner/sun8i-v3s.dtsi
+++ b/arch/arm/boot/dts/allwinner/sun8i-v3s.dtsi
@@ -71,7 +71,7 @@  cpus {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		cpu@0 {
+		cpu0: cpu@0 {
 			compatible = "arm,cortex-a7";
 			device_type = "cpu";
 			reg = <0>;