| Message ID | 20230825093531.7399-6-quic_nsekar@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | Enable IPQ5018 USB2 support | expand |
On 25/08/2023 11:35, Nitheesh Sekar wrote: > Enable USB2 in host mode. > > Co-developed-by: Amandeep Singh <quic_amansing@quicinc.com> > Signed-off-by: Amandeep Singh <quic_amansing@quicinc.com> > Signed-off-by: Nitheesh Sekar <quic_nsekar@quicinc.com> > --- > arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts b/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts > index e636a1cb9b77..cdf5e22ec54e 100644 > --- a/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts > +++ b/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts > @@ -70,3 +70,15 @@ > &xo_board_clk { > clock-frequency = <24000000>; > }; > + > +&usbphy0 { u is before x Best regards, Krzysztof
On 8/25/2023 4:08 PM, Krzysztof Kozlowski wrote: > On 25/08/2023 11:35, Nitheesh Sekar wrote: >> Enable USB2 in host mode. >> >> Co-developed-by: Amandeep Singh <quic_amansing@quicinc.com> >> Signed-off-by: Amandeep Singh <quic_amansing@quicinc.com> >> Signed-off-by: Nitheesh Sekar <quic_nsekar@quicinc.com> >> --- >> arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts b/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts >> index e636a1cb9b77..cdf5e22ec54e 100644 >> --- a/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts >> +++ b/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts >> @@ -70,3 +70,15 @@ >> &xo_board_clk { >> clock-frequency = <24000000>; >> }; >> + >> +&usbphy0 { > u is before x Sure, will sort and reorder the nodes. Regards, Nitheesh
On Fri, 25 Aug 2023 at 12:37, Nitheesh Sekar <quic_nsekar@quicinc.com> wrote: > > Enable USB2 in host mode. > > Co-developed-by: Amandeep Singh <quic_amansing@quicinc.com> > Signed-off-by: Amandeep Singh <quic_amansing@quicinc.com> > Signed-off-by: Nitheesh Sekar <quic_nsekar@quicinc.com> > --- > arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts b/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts > index e636a1cb9b77..cdf5e22ec54e 100644 > --- a/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts > +++ b/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts > @@ -70,3 +70,15 @@ > &xo_board_clk { > clock-frequency = <24000000>; > }; > + > +&usbphy0 { > + status = "okay"; > +}; > + > +&usb { > + status = "okay"; > +}; > + > +&usb2_0_dwc { > + dr_mode = "host"; > +}; Let me sort these for you: - usb - usb2_0_dwc - usbphy0 Like in a dictionary.
On 8/31/2023 1:41 AM, Dmitry Baryshkov wrote: > On Fri, 25 Aug 2023 at 12:37, Nitheesh Sekar <quic_nsekar@quicinc.com> wrote: >> Enable USB2 in host mode. >> >> Co-developed-by: Amandeep Singh <quic_amansing@quicinc.com> >> Signed-off-by: Amandeep Singh <quic_amansing@quicinc.com> >> Signed-off-by: Nitheesh Sekar <quic_nsekar@quicinc.com> >> --- >> arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts b/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts >> index e636a1cb9b77..cdf5e22ec54e 100644 >> --- a/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts >> +++ b/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts >> @@ -70,3 +70,15 @@ >> &xo_board_clk { >> clock-frequency = <24000000>; >> }; >> + >> +&usbphy0 { >> + status = "okay"; >> +}; >> + >> +&usb { >> + status = "okay"; >> +}; >> + >> +&usb2_0_dwc { >> + dr_mode = "host"; >> +}; > Let me sort these for you: > > - usb > - usb2_0_dwc > - usbphy0 > > Like in a dictionary. I will remove "2_0" in usb2_0_dwc and then sort and reorder the nodes again in the latest V2 version. Regards, Nitheesh
diff --git a/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts b/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts index e636a1cb9b77..cdf5e22ec54e 100644 --- a/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts +++ b/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts @@ -70,3 +70,15 @@ &xo_board_clk { clock-frequency = <24000000>; }; + +&usbphy0 { + status = "okay"; +}; + +&usb { + status = "okay"; +}; + +&usb2_0_dwc { + dr_mode = "host"; +};