| Message ID | 20230829073635.1877367-1-harshit.m.mogalapalli@oracle.com |
|---|---|
| State | Accepted |
| Commit | 9e07f8bfd959d2d09823430eab35d12182446dcf |
| Headers | show |
| Series | [next] ASoC: cs42l43: Fix missing error code in cs42l43_codec_probe() | expand |
On Tue, Aug 29, 2023 at 12:36:35AM -0700, Harshit Mogalapalli wrote: > When clk_get_optional() fails, the error handling code does a 'goto > err_pm' with ret = 0, which is resturning success on a failure path. > > Fix this by assigning the PTR_ERR(priv->mclk) to ret variable. > > Fixes: fc918cbe874e ("ASoC: cs42l43: Add support for the cs42l43") > Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> > --- Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com> Thanks, Charles
diff --git a/sound/soc/codecs/cs42l43.c b/sound/soc/codecs/cs42l43.c index 24e718e51174..1a95c370fc4c 100644 --- a/sound/soc/codecs/cs42l43.c +++ b/sound/soc/codecs/cs42l43.c @@ -2205,7 +2205,8 @@ static int cs42l43_codec_probe(struct platform_device *pdev) // Don't use devm as we need to get against the MFD device priv->mclk = clk_get_optional(cs42l43->dev, "mclk"); if (IS_ERR(priv->mclk)) { - dev_err_probe(priv->dev, PTR_ERR(priv->mclk), "Failed to get mclk\n"); + ret = PTR_ERR(priv->mclk); + dev_err_probe(priv->dev, ret, "Failed to get mclk\n"); goto err_pm; }
When clk_get_optional() fails, the error handling code does a 'goto err_pm' with ret = 0, which is resturning success on a failure path. Fix this by assigning the PTR_ERR(priv->mclk) to ret variable. Fixes: fc918cbe874e ("ASoC: cs42l43: Add support for the cs42l43") Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> --- This is based on static analysis with smatch, only compile tested. --- sound/soc/codecs/cs42l43.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)