| Message ID | 20230831073456.1713093-1-suhui@nfschina.com |
|---|---|
| State | Accepted |
| Commit | 83f5ad58daf1576640bec3aa2f81f003f8e6c48b |
| Headers | show |
| Series | [1/2] ACPICA: Use strscpy to replace strncpy | expand |
On Thu, Aug 31, 2023 at 9:35 AM Su Hui <suhui@nfschina.com> wrote: > > With gcc and W=1 option to compile kernel, warning happends: > > drivers/acpi/osl.c:156:2: error: > function ‘acpi_os_vprintf’ might be a candidate for ‘gnu_printf’ > format attribute [-Werror=suggest-attribute=format]. > > Allow the compiler to recognize and check format strings is safer. > > Signed-off-by: Su Hui <suhui@nfschina.com> > --- > drivers/acpi/osl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c > index f725813d0cce..357f1325485d 100644 > --- a/drivers/acpi/osl.c > +++ b/drivers/acpi/osl.c > @@ -149,7 +149,7 @@ void acpi_os_printf(const char *fmt, ...) > } > EXPORT_SYMBOL(acpi_os_printf); > > -void acpi_os_vprintf(const char *fmt, va_list args) > +void __printf(1, 0) acpi_os_vprintf(const char *fmt, va_list args) > { > static char buffer[512]; > > -- Applied (with some subject and changelog edits) as 6.7 material, thanks!
diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c index f725813d0cce..357f1325485d 100644 --- a/drivers/acpi/osl.c +++ b/drivers/acpi/osl.c @@ -149,7 +149,7 @@ void acpi_os_printf(const char *fmt, ...) } EXPORT_SYMBOL(acpi_os_printf); -void acpi_os_vprintf(const char *fmt, va_list args) +void __printf(1, 0) acpi_os_vprintf(const char *fmt, va_list args) { static char buffer[512];
With gcc and W=1 option to compile kernel, warning happends: drivers/acpi/osl.c:156:2: error: function ‘acpi_os_vprintf’ might be a candidate for ‘gnu_printf’ format attribute [-Werror=suggest-attribute=format]. Allow the compiler to recognize and check format strings is safer. Signed-off-by: Su Hui <suhui@nfschina.com> --- drivers/acpi/osl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)