diff mbox series

[BlueZ] bap: Fix not always calling bap_io_close on disconnect

Message ID 20230831220137.1164891-1-luiz.dentz@gmail.com
State New
Headers show
Series [BlueZ] bap: Fix not always calling bap_io_close on disconnect | expand

Commit Message

Luiz Augusto von Dentz Aug. 31, 2023, 10:01 p.m. UTC
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

bap_io_disconnected was getting registered for all links while
connecting which prevented bap_io_close to be called when ISO socket is
disconnected thus the cig_active flag will remain set preventing the IO
to be recreated.
---
 profiles/audio/bap.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

patchwork-bot+bluetooth@kernel.org Sept. 1, 2023, 4:54 p.m. UTC | #1
Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Thu, 31 Aug 2023 15:01:37 -0700 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> bap_io_disconnected was getting registered for all links while
> connecting which prevented bap_io_close to be called when ISO socket is
> disconnected thus the cig_active flag will remain set preventing the IO
> to be recreated.
> 
> [...]

Here is the summary with links:
  - [BlueZ] bap: Fix not always calling bap_io_close on disconnect
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=d06b912df5ab

You are awesome, thank you!
diff mbox series

Patch

diff --git a/profiles/audio/bap.c b/profiles/audio/bap.c
index 001a47bdc47b..9634ae4fc6c3 100644
--- a/profiles/audio/bap.c
+++ b/profiles/audio/bap.c
@@ -1936,6 +1936,8 @@  static void bap_connecting(struct bt_bap_stream *stream, bool state, int fd,
 
 	if (!ep->io) {
 		io = g_io_channel_unix_new(fd);
+		ep->io_id = g_io_add_watch(io, G_IO_HUP | G_IO_ERR | G_IO_NVAL,
+						bap_io_disconnected, ep);
 		ep->io = io;
 	} else
 		io = ep->io;