diff mbox series

[v2] spi: spi-mpc512x-psc: Fix an unsigned comparison that can never be negative

Message ID 20230903153720.3801-1-coolrrsh@gmail.com
State New
Headers show
Series [v2] spi: spi-mpc512x-psc: Fix an unsigned comparison that can never be negative | expand

Commit Message

coolrrsh@gmail.com Sept. 3, 2023, 3:37 p.m. UTC 
From: Rajeshwar R Shinde <coolrrsh@gmail.com>

In struct mpc512x_psc_spi, the variable 'irq' is declared as an
unsigned int. The comparison of variable 'irq'  with signed int
operand is incorrect. Also, the return value from the call to
platform_get_irq(pdev,0) is int and it is assigned to an unsigned
int variable 'irq', thus redeclaring the type of variable 'irq'
to signed int.

This fixes warning such as:
drivers/spi/spi-mpc512x-psc.c:493:5-13:
WARNING: Unsigned expression compared with zero: mps -> irq < 0

Signed-off-by: Rajeshwar R Shinde <coolrrsh@gmail.com>

---
v1->v2
changed the commit message

---
 drivers/spi/spi-mpc512x-psc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/drivers/spi/spi-mpc512x-psc.c b/drivers/spi/spi-mpc512x-psc.c
index 99aeef28a..5cecca1be 100644
--- a/drivers/spi/spi-mpc512x-psc.c
+++ b/drivers/spi/spi-mpc512x-psc.c
@@ -53,7 +53,7 @@  struct mpc512x_psc_spi {
 	int type;
 	void __iomem *psc;
 	struct mpc512x_psc_fifo __iomem *fifo;
-	unsigned int irq;
+	int irq;
 	u8 bits_per_word;
 	u32 mclk_rate;