| Message ID | 71c8d6d8c2c7ef31040ff5a0266cde0a6b3cd189.1693828363.git.geert+renesas@glider.be |
|---|---|
| State | New |
| Headers | show |
| Series | Restrict Mellanox platform and i2c dependencies | expand |
Hi Geert, On Mon, Sep 04, 2023 at 02:00:36PM +0200, Geert Uytterhoeven wrote: > The "i2c_mlxcpld" platform device is only instantiated on X86 systems > (through drivers/platform/x86/mlx-platform.c), or on ARM64 systems with > ACPI (through drivers/platform/mellanox/nvsw-sn2201.c). Hence further > restrict the dependency on ARM64 to ACPI, to prevent asking the user > about this driver when configuring an ARM64 kernel without ACPI support. > > While at it, document in the Kconfig help text that the driver supports > ARM64/ACPI based systems, too. > > Fixes: d7cf993f832ad2a4 ("i2c: mlxcpld: Allow driver to run on ARM64 architecture") I'd remove the fixes tag here, as well. > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Andi Shyti <andi.shyti@kernel.org> Andi
On Mon, Sep 04, 2023 at 02:00:36PM +0200, Geert Uytterhoeven wrote: > The "i2c_mlxcpld" platform device is only instantiated on X86 systems > (through drivers/platform/x86/mlx-platform.c), or on ARM64 systems with > ACPI (through drivers/platform/mellanox/nvsw-sn2201.c). Hence further > restrict the dependency on ARM64 to ACPI, to prevent asking the user > about this driver when configuring an ARM64 kernel without ACPI support. > > While at it, document in the Kconfig help text that the driver supports > ARM64/ACPI based systems, too. > > Fixes: d7cf993f832ad2a4 ("i2c: mlxcpld: Allow driver to run on ARM64 architecture") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Removed Fixes tag and applied to for-current, thanks!
diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig index 0aa97762332d8a87..bef2af50fb159baf 100644 --- a/drivers/i2c/busses/Kconfig +++ b/drivers/i2c/busses/Kconfig @@ -1391,10 +1391,10 @@ config I2C_ICY config I2C_MLXCPLD tristate "Mellanox I2C driver" - depends on X86_64 || ARM64 || COMPILE_TEST + depends on X86_64 || (ARM64 && ACPI) || COMPILE_TEST help This exposes the Mellanox platform I2C busses to the linux I2C layer - for X86 based systems. + for X86 and ARM64/ACPI based systems. Controller is implemented as CPLD logic. This driver can also be built as a module. If so, the module will be
The "i2c_mlxcpld" platform device is only instantiated on X86 systems (through drivers/platform/x86/mlx-platform.c), or on ARM64 systems with ACPI (through drivers/platform/mellanox/nvsw-sn2201.c). Hence further restrict the dependency on ARM64 to ACPI, to prevent asking the user about this driver when configuring an ARM64 kernel without ACPI support. While at it, document in the Kconfig help text that the driver supports ARM64/ACPI based systems, too. Fixes: d7cf993f832ad2a4 ("i2c: mlxcpld: Allow driver to run on ARM64 architecture") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/i2c/busses/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)