diff mbox series

[1/5] gpio: mockup: fix kerneldoc

Message ID 20230907145230.44085-1-brgl@bgdev.pl
State New
Headers show
Series [1/5] gpio: mockup: fix kerneldoc | expand

Commit Message

Bartosz Golaszewski Sept. 7, 2023, 2:52 p.m. UTC 
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

The pull field of the line state struct is undocumented. Fix it.

Fixes: 2a9e27408e12 ("gpio: mockup: rework debugfs interface")
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
 drivers/gpio/gpio-mockup.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Linus Walleij Sept. 11, 2023, 8:30 a.m. UTC | #1 
On Thu, Sep 7, 2023 at 4:52 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:

> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> The pull field of the line state struct is undocumented. Fix it.
>
> Fixes: 2a9e27408e12 ("gpio: mockup: rework debugfs interface")
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

For the whole series.

Yours,
Linus Walleij
diff mbox series

Patch

diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c
index b32063ac845a..17d4d48524b7 100644
--- a/drivers/gpio/gpio-mockup.c
+++ b/drivers/gpio/gpio-mockup.c
@@ -39,6 +39,8 @@ 
  * struct gpio_pin_status - structure describing a GPIO status
  * @dir:       Configures direction of gpio as "in" or "out"
  * @value:     Configures status of the gpio as 0(low) or 1(high)
+ * @pull:      Configures the current pull of the GPIO as 0 (pull-down) or
+ *             1 (pull-up)
  */
 struct gpio_mockup_line_status {
 	int dir;