diff mbox series

[3/4] ARM: dts: ti: omap: Fix noisy serial with overrun-throttle-ms for mapphone

Message ID 20230911040828.39386-3-tony@atomide.com
State New
Headers show
Series [1/4] ARM: dts: ti: omap: Fix bandgap thermal cells addressing for omap3/4 | expand

Commit Message

Tony Lindgren Sept. 11, 2023, 4:08 a.m. UTC
On mapphone devices we may get lots of noise on the micro-USB port in debug
uart mode until the phy-cpcap-usb driver probes. Let's limit the noise by
using overrun-throttle-ms.

Note that there is also a related separate issue where the charger cable
connected may cause random sysrq requests until phy-cpcap-usb probes that
still remains.

Cc: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
Cc: Carl Philipp Klemm <philipp@uvos.xyz>
Cc: Merlijn Wajer <merlijn@wizzup.org>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Sebastian Reichel <sre@kernel.org>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
 arch/arm/boot/dts/ti/omap/motorola-mapphone-common.dtsi | 1 +
 1 file changed, 1 insertion(+)

Comments

Sebastian Reichel Sept. 12, 2023, 3:31 p.m. UTC | #1
Hi,

On Mon, Sep 11, 2023 at 07:08:26AM +0300, Tony Lindgren wrote:
> On mapphone devices we may get lots of noise on the micro-USB port in debug
> uart mode until the phy-cpcap-usb driver probes. Let's limit the noise by
> using overrun-throttle-ms.
> 
> Note that there is also a related separate issue where the charger cable
> connected may cause random sysrq requests until phy-cpcap-usb probes that
> still remains.
> 
> Cc: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
> Cc: Carl Philipp Klemm <philipp@uvos.xyz>
> Cc: Merlijn Wajer <merlijn@wizzup.org>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Sebastian Reichel <sre@kernel.org>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---

A bit of a hack, but I guess it improves the status quo, so:

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>

-- Sebastian

>  arch/arm/boot/dts/ti/omap/motorola-mapphone-common.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/ti/omap/motorola-mapphone-common.dtsi b/arch/arm/boot/dts/ti/omap/motorola-mapphone-common.dtsi
> --- a/arch/arm/boot/dts/ti/omap/motorola-mapphone-common.dtsi
> +++ b/arch/arm/boot/dts/ti/omap/motorola-mapphone-common.dtsi
> @@ -640,6 +640,7 @@ &uart1 {
>  &uart3 {
>  	interrupts-extended = <&wakeupgen GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH
>  			       &omap4_pmx_core 0x17c>;
> +	overrun-throttle-ms = <500>;
>  };
>  
>  &uart4 {
> -- 
> 2.42.0
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/ti/omap/motorola-mapphone-common.dtsi b/arch/arm/boot/dts/ti/omap/motorola-mapphone-common.dtsi
--- a/arch/arm/boot/dts/ti/omap/motorola-mapphone-common.dtsi
+++ b/arch/arm/boot/dts/ti/omap/motorola-mapphone-common.dtsi
@@ -640,6 +640,7 @@  &uart1 {
 &uart3 {
 	interrupts-extended = <&wakeupgen GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH
 			       &omap4_pmx_core 0x17c>;
+	overrun-throttle-ms = <500>;
 };
 
 &uart4 {