| Message ID | 20230911133026.29868-1-quic_bibekkum@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] mtd: nand: qcom: Fix the node for nand unmap resource | expand |
On 9/11/2023 9:10 PM, Miquel Raynal wrote: > Hi Bibek, > > quic_bibekkum@quicinc.com wrote on Mon, 11 Sep 2023 19:00:26 +0530: > > The title prefix should be s/nand/rawnand. > > The title itself is unclear "fix the node" does not mean anything to me. > sure Miquel, will rectify the prefix and give a meaningful title in the next patch. >> Fix addr argument to dma_unmap_resource() in the error path of probe. > > ^ > No abbreviation unless you are quoting the code directly. > > of? probe error path > >> The addr argument should be dma address instead of physical address. > ^ ^ ^ > ditto the? the? > Thanks for these pointers, will revise the commit message removing abbreviations and making other changes as suggested. Thanks, Bibek >> >> Fixes: 7330fc505af4 ("mtd: rawnand: qcom: stop using phys_to_dma()") >> Signed-off-by: Bibek Kumar Patro <quic_bibekkum@quicinc.com> >> --- >> v2: Incorporated comments from Pavan/Mani. >> >> v1: https://lore.kernel.org/all/20230907092854.11408-1-quic_bibekkum@quicinc.com/ >> >> drivers/mtd/nand/raw/qcom_nandc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/mtd/nand/raw/qcom_nandc.c b/drivers/mtd/nand/raw/qcom_nandc.c >> index 64499c1b3603..b079605c84d3 100644 >> --- a/drivers/mtd/nand/raw/qcom_nandc.c >> +++ b/drivers/mtd/nand/raw/qcom_nandc.c >> @@ -3444,7 +3444,7 @@ static int qcom_nandc_probe(struct platform_device *pdev) >> err_aon_clk: >> clk_disable_unprepare(nandc->core_clk); >> err_core_clk: >> - dma_unmap_resource(dev, res->start, resource_size(res), >> + dma_unmap_resource(dev, nandc->base_dma, resource_size(res), >> DMA_BIDIRECTIONAL, 0); >> return ret; >> } >> -- >> 2.17.1 >> > > > Thanks, > Miquèl
diff --git a/drivers/mtd/nand/raw/qcom_nandc.c b/drivers/mtd/nand/raw/qcom_nandc.c index 64499c1b3603..b079605c84d3 100644 --- a/drivers/mtd/nand/raw/qcom_nandc.c +++ b/drivers/mtd/nand/raw/qcom_nandc.c @@ -3444,7 +3444,7 @@ static int qcom_nandc_probe(struct platform_device *pdev) err_aon_clk: clk_disable_unprepare(nandc->core_clk); err_core_clk: - dma_unmap_resource(dev, res->start, resource_size(res), + dma_unmap_resource(dev, nandc->base_dma, resource_size(res), DMA_BIDIRECTIONAL, 0); return ret; }
Fix addr argument to dma_unmap_resource() in the error path of probe. The addr argument should be dma address instead of physical address. Fixes: 7330fc505af4 ("mtd: rawnand: qcom: stop using phys_to_dma()") Signed-off-by: Bibek Kumar Patro <quic_bibekkum@quicinc.com> --- v2: Incorporated comments from Pavan/Mani. v1: https://lore.kernel.org/all/20230907092854.11408-1-quic_bibekkum@quicinc.com/ drivers/mtd/nand/raw/qcom_nandc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1