diff mbox series

[01/11] exec: Make EXCP_FOO definitions target agnostic

Message ID 20230914185718.76241-2-philmd@linaro.org
State Superseded
Headers show
Series accel/tcg: Make more files target agnostic (& exec/ housekeeping) | expand

Commit Message

Philippe Mathieu-Daudé Sept. 14, 2023, 6:57 p.m. UTC
The EXCP_* definitions don't need to be target specific,
move them to "exec/cpu-common.h".

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 include/exec/cpu-all.h    | 7 -------
 include/exec/cpu-common.h | 7 +++++++
 2 files changed, 7 insertions(+), 7 deletions(-)

Comments

Anton Johansson Sept. 15, 2023, 1:24 p.m. UTC | #1
On 14/09/23, Philippe Mathieu-Daudé wrote:
> The EXCP_* definitions don't need to be target specific,
> move them to "exec/cpu-common.h".
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  include/exec/cpu-all.h    | 7 -------
>  include/exec/cpu-common.h | 7 +++++++
>  2 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h
> index 3b1cec390b..71efc2d404 100644
> --- a/include/exec/cpu-all.h
> +++ b/include/exec/cpu-all.h
> @@ -26,13 +26,6 @@
>  #include "hw/core/cpu.h"
>  #include "qemu/rcu.h"
>  
> -#define EXCP_INTERRUPT  0x10000 /* async interruption */
> -#define EXCP_HLT        0x10001 /* hlt instruction reached */
> -#define EXCP_DEBUG      0x10002 /* cpu stopped after a breakpoint or singlestep */
> -#define EXCP_HALTED     0x10003 /* cpu is halted (waiting for external event) */
> -#define EXCP_YIELD      0x10004 /* cpu wants to yield timeslice to another */
> -#define EXCP_ATOMIC     0x10005 /* stop-the-world and emulate atomic */
> -
>  /* some important defines:
>   *
>   * HOST_BIG_ENDIAN : whether the host cpu is big endian and
> diff --git a/include/exec/cpu-common.h b/include/exec/cpu-common.h
> index 41788c0bdd..360b8298a4 100644
> --- a/include/exec/cpu-common.h
> +++ b/include/exec/cpu-common.h
> @@ -7,6 +7,13 @@
>  #include "exec/hwaddr.h"
>  #endif
>  
> +#define EXCP_INTERRUPT  0x10000 /* async interruption */
> +#define EXCP_HLT        0x10001 /* hlt instruction reached */
> +#define EXCP_DEBUG      0x10002 /* cpu stopped after a breakpoint or singlestep */
> +#define EXCP_HALTED     0x10003 /* cpu is halted (waiting for external event) */
> +#define EXCP_YIELD      0x10004 /* cpu wants to yield timeslice to another */
> +#define EXCP_ATOMIC     0x10005 /* stop-the-world and emulate atomic */
> +
>  /**
>   * vaddr:
>   * Type wide enough to contain any #target_ulong virtual address.
> -- 
> 2.41.0
> 
Reviewed-by: Anton Johansson <anjo@rev.ng>
diff mbox series

Patch

diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h
index 3b1cec390b..71efc2d404 100644
--- a/include/exec/cpu-all.h
+++ b/include/exec/cpu-all.h
@@ -26,13 +26,6 @@ 
 #include "hw/core/cpu.h"
 #include "qemu/rcu.h"
 
-#define EXCP_INTERRUPT  0x10000 /* async interruption */
-#define EXCP_HLT        0x10001 /* hlt instruction reached */
-#define EXCP_DEBUG      0x10002 /* cpu stopped after a breakpoint or singlestep */
-#define EXCP_HALTED     0x10003 /* cpu is halted (waiting for external event) */
-#define EXCP_YIELD      0x10004 /* cpu wants to yield timeslice to another */
-#define EXCP_ATOMIC     0x10005 /* stop-the-world and emulate atomic */
-
 /* some important defines:
  *
  * HOST_BIG_ENDIAN : whether the host cpu is big endian and
diff --git a/include/exec/cpu-common.h b/include/exec/cpu-common.h
index 41788c0bdd..360b8298a4 100644
--- a/include/exec/cpu-common.h
+++ b/include/exec/cpu-common.h
@@ -7,6 +7,13 @@ 
 #include "exec/hwaddr.h"
 #endif
 
+#define EXCP_INTERRUPT  0x10000 /* async interruption */
+#define EXCP_HLT        0x10001 /* hlt instruction reached */
+#define EXCP_DEBUG      0x10002 /* cpu stopped after a breakpoint or singlestep */
+#define EXCP_HALTED     0x10003 /* cpu is halted (waiting for external event) */
+#define EXCP_YIELD      0x10004 /* cpu wants to yield timeslice to another */
+#define EXCP_ATOMIC     0x10005 /* stop-the-world and emulate atomic */
+
 /**
  * vaddr:
  * Type wide enough to contain any #target_ulong virtual address.