| Message ID | 20230914195229.78244-5-philmd@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | accel/tcg: Stubs cleanups | expand |
On 9/15/23 01:22, Philippe Mathieu-Daudé wrote: > Since commit 34d49937e4 ("accel/tcg: Handle atomic accesses > to notdirty memory correctly") tlb_set_dirty() is only used > (once) in the very same file it is defined... Make it static. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> Reviewed-by: Harsh Prateek Bora <harshpb@linux.ibm.com> > --- > include/exec/exec-all.h | 1 - > accel/tcg/cputlb.c | 2 +- > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h > index b2f5cd4c2a..59efa7bc28 100644 > --- a/include/exec/exec-all.h > +++ b/include/exec/exec-all.h > @@ -695,7 +695,6 @@ static inline void mmap_unlock(void) {} > #define WITH_MMAP_LOCK_GUARD() > > void tlb_reset_dirty(CPUState *cpu, ram_addr_t start1, ram_addr_t length); > -void tlb_set_dirty(CPUState *cpu, vaddr addr); > > MemoryRegionSection * > address_space_translate_for_iotlb(CPUState *cpu, int asidx, hwaddr addr, > diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c > index c643d66190..fe9d702f3e 100644 > --- a/accel/tcg/cputlb.c > +++ b/accel/tcg/cputlb.c > @@ -1062,7 +1062,7 @@ static inline void tlb_set_dirty1_locked(CPUTLBEntry *tlb_entry, > > /* update the TLB corresponding to virtual page vaddr > so that it is no longer dirty */ > -void tlb_set_dirty(CPUState *cpu, vaddr addr) > +static void tlb_set_dirty(CPUState *cpu, vaddr addr) > { > CPUArchState *env = cpu->env_ptr; > int mmu_idx;
diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h index b2f5cd4c2a..59efa7bc28 100644 --- a/include/exec/exec-all.h +++ b/include/exec/exec-all.h @@ -695,7 +695,6 @@ static inline void mmap_unlock(void) {} #define WITH_MMAP_LOCK_GUARD() void tlb_reset_dirty(CPUState *cpu, ram_addr_t start1, ram_addr_t length); -void tlb_set_dirty(CPUState *cpu, vaddr addr); MemoryRegionSection * address_space_translate_for_iotlb(CPUState *cpu, int asidx, hwaddr addr, diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c index c643d66190..fe9d702f3e 100644 --- a/accel/tcg/cputlb.c +++ b/accel/tcg/cputlb.c @@ -1062,7 +1062,7 @@ static inline void tlb_set_dirty1_locked(CPUTLBEntry *tlb_entry, /* update the TLB corresponding to virtual page vaddr so that it is no longer dirty */ -void tlb_set_dirty(CPUState *cpu, vaddr addr) +static void tlb_set_dirty(CPUState *cpu, vaddr addr) { CPUArchState *env = cpu->env_ptr; int mmu_idx;
Since commit 34d49937e4 ("accel/tcg: Handle atomic accesses to notdirty memory correctly") tlb_set_dirty() is only used (once) in the very same file it is defined... Make it static. Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- include/exec/exec-all.h | 1 - accel/tcg/cputlb.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-)